Commitcc59ca7

committed

minor#10125 Use callable classes for custom Monolog processors (jaikdean)

This PR was merged into the 2.8 branch.Discussion----------Use callable classes for custom Monolog processorsThe built-in Monolog processors all use callable classes with an `__invoke()` method, whereas the Symfony documentation uses a `processRecord()` method. Using `__invoke()` provides consistency with the standard processors and also removes the need to specify the method name in the service configuration.Commits-------6f1a0f3 Use callable classes for custom Monolog processors

2 parentsc7b9cf1 +6f1a0f3 commitcc59ca7Copy full SHA for cc59ca7

File tree

1 file changed

+10

-10

lines changed

logging
- processors.rst

1 file changed

+10

-10

lines changed

`‎logging/processors.rst‎`

Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ using a processor::`
`30`	`30`	`$this->session = $session;`
`31`	`31`	`}`
`32`	`32`
`33`		`- public functionprocessRecord(array $record)`
	`33`	`+ public function__invoke(array $record)`
`34`	`34`	`{`
`35`	`35`	`if (!$this->session->isStarted()) {`
`36`	`36`	`return $record;`
`@@ -61,7 +61,7 @@ using a processor::`
`61`	`61`	`class:AppBundle\Logger\SessionRequestProcessor`
`62`	`62`	`arguments:['@session']`
`63`	`63`	`tags:`
`64`		`- -{ name: monolog.processor, method: processRecord }`
	`64`	`+ -{ name: monolog.processor }`
`65`	`65`
`66`	`66`	`monolog:`
`67`	`67`	`handlers:`
`@@ -94,7 +94,7 @@ using a processor::`
`94`	`94`	`class="AppBundle\Logger\SessionRequestProcessor">`
`95`	`95`
`96`	`96`	`<argumenttype="service"id="session" />`
`97`		`- <tagname="monolog.processor"method="processRecord"/>`
	`97`	`+ <tagname="monolog.processor" />`
`98`	`98`	`</service>`
`99`	`99`	`</services>`
`100`	`100`
`@@ -122,7 +122,7 @@ using a processor::`
`122`	`122`	`$container`
`123`	`123`	`->register('app.logger.session_request_processor', SessionRequestProcessor::class)`
`124`	`124`	`->addArgument(new Reference('session'))`
`125`		`- ->addTag('monolog.processor', array('method' => 'processRecord'));`
	`125`	`+ ->addTag('monolog.processor');`
`126`	`126`
`127`	`127`	`$container->loadFromExtension('monolog', array(`
`128`	`128`	`'handlers' => array(`
@@ -157,7 +157,7 @@ the ``monolog.processor`` tag:
`157`	`157`	`class:AppBundle\Logger\SessionRequestProcessor`
`158`	`158`	`arguments:['@session']`
`159`	`159`	`tags:`
`160`		`- -{ name: monolog.processor,method: processRecord,handler: main }`
	`160`	`+ -{ name: monolog.processor, handler: main }`
`161`	`161`
`162`	`162`	`..code-block::xml`
`163`	`163`
@@ -176,7 +176,7 @@ the ``monolog.processor`` tag:
`176`	`176`	`class="AppBundle\Logger\SessionRequestProcessor">`
`177`	`177`
`178`	`178`	`<argument type="service" id="session" />`
`179`		`- <tag name="monolog.processor"method="processRecord"handler="main" />`
	`179`	`+ <tag name="monolog.processor" handler="main" />`
`180`	`180`	`</service>`
`181`	`181`	`</services>`
`182`	`182`	`</container>`
@@ -192,7 +192,7 @@ the ``monolog.processor`` tag:
`192`	`192`	`SessionRequestProcessor::class`
`193`	`193`	`)`
`194`	`194`	`->addArgument(new Reference('session'))`
`195`		`- ->addTag('monolog.processor', array('method' => 'processRecord', 'handler' => 'main'));`
	`195`	`+ ->addTag('monolog.processor', array('handler' => 'main'));`
`196`	`196`
`197`	`197`	`Registering Processors per Channel`
`198`	`198`	`----------------------------------`
@@ -210,7 +210,7 @@ the ``monolog.processor`` tag:
`210`	`210`	`class: AppBundle\Logger\SessionRequestProcessor`
`211`	`211`	`arguments: ['@session']`
`212`	`212`	`tags:`
`213`		`- - { name: monolog.processor,method: processRecord,channel: main }`
	`213`	`+ - { name: monolog.processor, channel: main }`
`214`	`214`
`215`	`215`	`.. code-block:: xml`
`216`	`216`
@@ -229,7 +229,7 @@ the ``monolog.processor`` tag:
`229`	`229`	`class="AppBundle\Logger\SessionRequestProcessor">`
`230`	`230`
`231`	`231`	`<argument type="service" id="session" />`
`232`		`- <tag name="monolog.processor"method="processRecord"channel="main" />`
	`232`	`+ <tag name="monolog.processor" channel="main" />`
`233`	`233`	`</service>`
`234`	`234`	`</services>`
`235`	`235`	`</container>`
@@ -242,4 +242,4 @@ the ``monolog.processor`` tag:
`242`	`242`	`$container`
`243`	`243`	`->register('app.logger.session_request_processor', SessionRequestProcessor::class)`
`244`	`244`	`->addArgument(new Reference('session'))`
`245`		`- ->addTag('monolog.processor', array('method' => 'processRecord', 'channel' => 'main'));`
	`245`	`+ ->addTag('monolog.processor', array('channel' => 'main'));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitcc59ca7

File tree

1 file changed

1 file changed

`‎logging/processors.rst‎`

0 commit comments