Commitc0676f3

committed

minor#5597 [CreateFramework] don't override existing variables (xabbuh)

This PR was merged into the 2.3 branch.Discussion----------[CreateFramework] don't override existing variables| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |#5568When extracting the request attributes, existing variables must not beoverridden so that the `$request` variable is passed to the template asis.Commits-------4b23fdc don't override existing variables

2 parentsf452b6e +4b23fdc commitc0676f3Copy full SHA for c0676f3

File tree

1 file changed

-2

lines changed

create_framework
- templating.rst

1 file changed

-2

lines changed

`‎create_framework/templating.rst‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ rendered::`
`41`	`41`
`42`	`42`	`function render_template($request)`
`43`	`43`	`{`
`44`		`- extract($request->attributes->all());`
	`44`	`+ extract($request->attributes->all(), EXTR_SKIP);`
`45`	`45`	`ob_start();`
`46`	`46`	`include sprintf(__DIR__.'/../src/pages/%s.php', $_route);`
`47`	`47`
`@@ -110,7 +110,7 @@ Here is the updated and improved version of our framework::`
`110`	`110`
`111`	`111`	`function render_template($request)`
`112`	`112`	`{`
`113`		`- extract($request->attributes->all());`
	`113`	`+ extract($request->attributes->all(), EXTR_SKIP);`
`114`	`114`	`ob_start();`
`115`	`115`	`include sprintf(__DIR__.'/../src/pages/%s.php', $_route);`
`116`	`116`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc0676f3

File tree

1 file changed

1 file changed

`‎create_framework/templating.rst‎`

0 commit comments