Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Commitaedefdd
committed
minor#9526 [Encore] Don't enable the Sass loader at the beginning of the First Example page (Lyrkan)
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#9526).Discussion----------[Encore] Don't enable the Sass loader at the beginning of the First Example pageSomeone pointed out insymfony/webpack-encore#287 that if you follow the [First example](http://symfony.com/doc/master/frontend/encore/simple-example.html) page from top to bottom you are going to run `yarn encore` before being informed that calling `enableSassLoader()` implies adding additional dependencies (which is done just after).~~This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.~~~~I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.~~**Edit:** Changed it so `enableSassLoader()` is commented before running Encore for the first timeCommits-------18586e2 [Encore] Don't enable the Sass loader at the beginning of the First Example page1 file changed
+39
-12
lines changed| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| ||||
5 | 5 | | ||
6 | 6 | | ||
7 | 7 | | ||
8 | | - | ||
| 8 | + | ||
9 | 9 | | ||
10 | 10 | | ||
11 | 11 | | 12 | |
13 | 13 | | ||
14 | 14 | | ||
15 | 15 | | ||
16 | | - | ||
| 16 | + | ||
17 | 17 | | ||
18 | 18 | | ||
19 | 19 | | ||
20 | | - | ||
21 | | - | ||
| 20 | + | ||
| 21 | + | ||
22 | 22 | | ||
23 | 23 | | ||
24 | 24 | | ||
| ||||
41 | 41 | | ||
42 | 42 | | ||
43 | 43 | | ||
44 | | - | ||
45 | | - | ||
46 | | - | ||
47 | 44 | | ||
48 | 45 | | ||
49 | 46 | | ||
| 47 | + | ||
50 | 48 | | ||
51 | 49 | | ||
52 | 50 | | ||
| ||||
57 | 55 | | ||
58 | 56 | | ||
59 | 57 | | ||
| 58 | + | ||
| 59 | + | ||
| 60 | + | ||
60 | 61 | | ||
61 | 62 | | ||
62 | 63 | | ||
63 | 64 | | ||
64 | 65 | | ||
65 | | - | ||
66 | | - | ||
| 66 | + | ||
| 67 | + | ||
67 | 68 | | ||
68 | 69 | | ||
69 | 70 | | ||
| ||||
89 | 90 | | ||
90 | 91 | | ||
91 | 92 | | ||
92 | | - | ||
93 | | - | ||
94 | | - | ||
95 | 93 | | ||
96 | 94 | | ||
97 | 95 | | ||
| ||||
111 | 109 | | ||
112 | 110 | | ||
113 | 111 | | ||
| 112 | + | ||
| 113 | + | ||
| 114 | + | ||
| 115 | + | ||
| 116 | + | ||
| 117 | + | ||
| 118 | + | ||
| 119 | + | ||
| 120 | + | ||
| 121 | + | ||
| 122 | + | ||
| 123 | + | ||
| 124 | + | ||
| 125 | + | ||
| 126 | + | ||
| 127 | + | ||
| 128 | + | ||
| 129 | + | ||
| 130 | + | ||
| 131 | + | ||
| 132 | + | ||
| 133 | + | ||
| 134 | + | ||
| 135 | + | ||
| 136 | + | ||
| 137 | + | ||
| 138 | + | ||
| 139 | + | ||
| 140 | + | ||
114 | 141 | | ||
115 | 142 | | ||
116 | 143 | | ||
| ||||
0 commit comments
Comments
(0)