Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Commita71a0cb
committed
minor#21530 [Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory (nicuserban)
This PR was merged into the 7.3 branch.Discussion----------[Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactoryIn this PRhttps://github.com/symfony/symfony-docs/pull/21507/files , when pointing out that constructor property promotion should not be used when injecting `$lockFactory`, I also wrongly introduced a `parent::__construct()` call. As in the current example attribute is used and the example command class is no longer extending `Symfony\Component\Console\Command\Command`, the call to the constructor of the parent class is actually wrong.I just wanted to fix this and to apologize for any inconvenience I caused with the back-and-forth related to this issue.<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `7.x` for features of unreleased versions).-->Commits-------2f91e30 [Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
65 | 63 | | |
66 | 64 | | |
67 | 65 | | |
| |||
0 commit comments
Comments
(0)