Commita12bbd6

committed

minor#6365 Removed the PR table example (this is now included by GitHub template) (javiereguiluz)

This PR was merged into the 2.3 branch.Discussion----------Removed the PR table example (this is now included by GitHub template)Thisfixes#6357Commits-------a6fe200 Removed the PR table example (this is now included by GitHub template)

2 parentsf5f49d8 +a6fe200 commita12bbd6Copy full SHA for a12bbd6

File tree

1 file changed

-43

lines changed

contributing/code
- patches.rst

1 file changed

-43

lines changed

`‎contributing/code/patches.rst‎`

Lines changed: 4 additions & 43 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,49 +266,10 @@ pull request message, like in:`
`266`	`266`	`[Yaml] fixed something`
`267`	`267`	`[Form] [Validator] [FrameworkBundle] added something`
`268`	`268`
`269`		`-The pull request description must include the following checklist at the top`
`270`		`-to ensure that contributions may be reviewed without needless feedback`
`271`		`-loops and that your contributions can be included into Symfony as quickly as`
`272`		`-possible:`
`273`		`-`
`274`		`-..code-block::text`
`275`		`-`
`276`		`- \| Q \| A`
`277`		`- \| ------------- \| ---`
`278`		`- \| Bug fix? \| [yes\|no]`
`279`		`- \| New feature? \| [yes\|no]`
`280`		`- \| BC breaks? \| [yes\|no]`
`281`		`- \| Deprecations? \| [yes\|no]`
`282`		`- \| Tests pass? \| [yes\|no]`
`283`		`- \| Fixed tickets \| [comma separated list of tickets fixed by the PR]`
`284`		`- \| License \| MIT`
`285`		`- \| Doc PR \| [The reference to the documentation PR if any]`
`286`		`-`
`287`		`-An example submission could now look as follows:`
`288`		`-`
`289`		`-..code-block::text`
`290`		`-`
`291`		`- \| Q \| A`
`292`		`- \| ------------- \| ---`
`293`		`- \| Bug fix? \| no`
`294`		`- \| New feature? \| no`
`295`		`- \| BC breaks? \| no`
`296`		`- \| Deprecations? \| no`
`297`		`- \| Tests pass? \| yes`
`298`		`- \| Fixed tickets \| #12, #43`
`299`		`- \| License \| MIT`
`300`		`- \| Doc PR \| symfony/symfony-docs#123`
`301`		`-`
`302`		`-The whole table must be included (do not remove lines that you think are`
`303`		`-not relevant). For simple typos, minor changes in the PHPDocs, or changes in`
`304`		`-translation files, use the shorter version of the check-list:`
`305`		`-`
`306`		`-..code-block::text`
`307`		`-`
`308`		`- \| Q \| A`
`309`		`- \| ------------- \| ---`
`310`		`- \| Fixed tickets \| [comma separated list of tickets fixed by the PR]`
`311`		`- \| License \| MIT`
	`269`	`+The default pull request description contains a table which you must fill in`
	`270`	`+with the appropriate answers. This ensures that contributions may be reviewed`
	`271`	`+without needless feedback loops and that your contributions can be included into`
	`272`	`+Symfony as quickly as possible:`
`312`	`273`
`313`	`274`	`Some answers to the questions trigger some more requirements:`
`314`	`275`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commita12bbd6

File tree

1 file changed

1 file changed

`‎contributing/code/patches.rst‎`

0 commit comments