Commit9b330ef

committed

feature#4507 Comply with best practices, Round 2 (WouterJ)

This PR was merged into the 2.3 branch.Discussion----------Comply with best practices, Round 2| Q | A| --- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | partly#4431Less other fixes, more find/replace this time to speed up the process. I have one question this time:* Should we just mention the use of the param converter (the current case), or update all simple controller examples to the use param converter?Commits-------5ee9791 Some fixesfdc460d Minor standard fix for best practices guide2a97453 Minor tweaka29f9fb Don't use form() helper4ef1ef3 Apply best practices to formsde4fcf4 Use AppBundle instead of AcmeStoreBundlec8ce507 Other minor fixes3c71b6d Use AppBundle instead of AcmeDemoBundle

2 parentsd203e5a +5ee9791 commit9b330efCopy full SHA for 9b330ef

File tree

4 files changed

+199

-241

lines changed

best_practices
- forms.rst
book

4 files changed

+199

-241

lines changed

`‎best_practices/forms.rst‎`

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,7 @@ Building Forms`
`15`	`15`	`The Form component allows you to build forms right inside your controller`
`16`	`16`	`code. Honestly, unless you need to reuse the form somewhere else, that's`
`17`	`17`	`totally fine. But for organize and reuse, we recommend that you define each`
`18`		`-form in its own PHP class:`
`19`		`-`
`20`		`-..code-block::php`
	`18`	`+form in its own PHP class::`
`21`	`19`
`22`	`20`	`namespace AppBundle\Form;`
`23`	`21`
`@@ -51,9 +49,7 @@ form in its own PHP class:`
`51`	`49`	`}`
`52`	`50`	`}`
`53`	`51`
`54`		-To use the class, use ``createForm`` and instantiate the new class:
`55`		`-`
`56`		`-..code-block::php`
	`52`	+To use the class, use ``createForm`` and instantiate the new class::
`57`	`53`
`58`	`54`	`use AppBundle\Form\PostType;`
`59`	`55`	`// ...`
`@@ -110,9 +106,7 @@ directly in your form class, this would effectively limit the scope of that form`
`110`	`106`
`111`	`107`	`This form may have been designed for creating posts, but if you wanted`
`112`	`108`	`to reuse it for editing posts, the button label would be wrong. Instead,`
`113`		`-some developers configure form buttons in the controller:`
`114`		`-`
`115`		`-..code-block::php`
	`109`	`+some developers configure form buttons in the controller::`
`116`	`110`
`117`	`111`	`namespace AppBundle\Controller\Admin;`
`118`	`112`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit9b330ef

File tree

4 files changed

4 files changed

`‎best_practices/forms.rst‎`

0 commit comments