Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Add input step attribute if with_seconds enabled#9976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
konandrum wants to merge3 commits intosymfony:masterfromkonandrum:master
Closed

[Form] Add input step attribute if with_seconds enabled#9976

konandrum wants to merge3 commits intosymfony:masterfromkonandrum:master

Conversation

@konandrum
Copy link

No description provided.

@hacfi
Copy link
Contributor

@idciconsulting Won’t this make it impossible to overwritestep with the form options attr property?

@konandrum
Copy link
Author

Great idea, I suggest two possibilities:

  • first change the with_seconds parameter type from boolean to an integer for exemple, and use the given value as the step (or rename this field because with_... sound to be a boolean).
  • second add a new parameter call step for exemple, and use it if the with_second is 'true'. (But if this value is set to 0 this could became the with_seconds parameter useless)

Your opinion ?

@fabpot
Copy link
Member

Closing in favor of#10777

@fabpotfabpot closed thisMay 16, 2014
fabpot added a commit that referenced this pull requestMay 16, 2014
…ets to display seconds if needed (tucksaun)This PR was squashed before being merged into the 2.3 branch (closes#10777).Discussion----------[Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#9976,#10203| License       | MIT| Doc PR        | noneSame issue as#9976 and#10203: when you add a `time` field to a form with options `single_text` (so HTML5) and `with_seconds`, the generated input does not contain the `step` attribute, therefore the browser does not show them, leading to an error at the submit because of an invalid format.Compared to#9976/#10203:* Unit testable* Available directly in the component* Available in other templating format than twig* Still able to customise the step attribute by handCommits-------a379298 [Form] Automatically add step attribute to HTML5 time widgets to display seconds if needed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@konandrum@hacfi@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp