It turns out that the previous approach, using recursive iterators, couldn't work in practise. That's why I introduce, with the help of@igorw, a new approach. When using it normally, it can be accessed as an array and when iterating it will iterate only over the root errors (this is BC). When callingFormErrorBag->getAllErrors() aRecursiveArrayIterator is returned, iterating over all errors.

wouterj added3 commits

December 28, 2013 15:21

Created FormErrorBag

725d9ee

This is fully BC with returning an array and it deprecatesForm::getErrorsAsString()

Fixed test

b6bc8c0

Refactored FormErrorBag

ed4ba1a

It's now an IteratorAggregate with ArrayAccess. At normal use, it onlyreturns the root errors. When calling FormErrorBag#getAllErrors() it willreturn a RecursiveArrayIterator, iterating over all form errors.

wouterj mentioned this pull request

Dec 31, 2013

[Form] Created FormErrorBag#9099

Closed

4 tasks

Copy link

Member

stof commentedDec 31, 2013

you need to clone the FormErrorBag when cloning the Form as it is an object now. Otherwise errors will be shared between both forms

stof reviewed

Dec 31, 2013

View reviewed changes

src/Symfony/Component/Form/Form.php


		// for BC
		if (is_array($childrenErrors)) {
		$_collection = new FormErrorBag();

Copy link

Member

stofDec 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we don't use the leading undescore in Symfony

Copy link

Contributor

webmozart commentedDec 31, 2013

I thinkadding the errors to the bags is problematic, because now we store the errors in two different locations which we need to synchronize. I found a better and simpler approach using just iterators now that I'm going to post as PR shortly. That approach is somewhat similar to yours, but uses a different perspective (temporary iterators instead of permanent bags).