Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BrowserKit] added override power to server parameters provided on request method#9901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cordoval commentedDec 30, 2013
@fabpot ^^ 👶 |
stof commentedDec 30, 2013
why is it tagged as |
cordoval commentedDec 30, 2013
@stof not accurate, @bschussek is guilty of the same usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be moved to the new method as well (that was my point).
cordoval commentedDec 30, 2013
@fabpot 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not covered by the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Afaik valid values areOn andOff (At least in apache)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch, checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@staabm it varies widely but inside this class at least it is true or false which makes sense on the usage elsewhere
cordoval commentedDec 30, 2013
fabpot commentedDec 31, 2013
@stof is right, we are not using WCM here. The only thing we have is |
cordoval commentedDec 31, 2013
@fabpot fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
?! Changing a test so that it matches your implementation is just plain wrong.
fabpot commentedMar 27, 2014
Closing in favor of#10549 |
This PR was merged into the 2.3 branch.Discussion----------Fixed server values in BrowserKit| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#9527,#9762,#9821,#9901| License | MIT| Doc PR | n/aCommits-------65b9810 fixed too greedy replacementsd9cf28d fixed protocol-relative URLs289da16 added override power to server parameters provided on request method
supersedes#9821