Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Moved DoctrineCache to Doctrine Bridge#9898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
florianv wants to merge1 commit intosymfony:masterfromflorianv:validator-cache

Conversation

florianv
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

As per@stof remark on#9892 theDoctrineCache class should be located in the Doctrine Bridge.

@fabpot
Copy link
Member

Not sure this is a good idea. As this is the only/main way to enable the cache, it's more than just integrating Doctrine with the Validator. So, I'm -1.

@florianv
Copy link
ContributorAuthor

@fabpot There is a similar case withDoctrineParserCache (https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/ExpressionLanguage/DoctrineParserCache.php).
Should we create an issue to move this class to the ExpressionLanguage component and deprecate theArrayParserCache (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/ExpressionLanguage/ParserCache/ArrayParserCache.php) ? To keep consistency.

@fabpot
Copy link
Member

No, both cases are quite different if you ask me.

@florianvflorianv deleted the validator-cache branchJanuary 26, 2014 11:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@florianv@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp