NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[WIP] [Console] added a better way to ask questions to the user#9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fabpot wants to merge1 commit intosymfony:masterfromfabpot:console-question

Closed

[WIP] [Console] added a better way to ask questions to the user#9811

fabpot wants to merge1 commit intosymfony:masterfromfabpot:console-question

Conversation

Copy link

Member

fabpot commentedDec 18, 2013

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	not yet

Todo:

add missing phpdocs
add unit tests
submit doc PR

cordoval reviewed

Dec 18, 2013

View reviewed changes

src/Symfony/Component/Console/Helper/QuestionHelper.php

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why not using a new Process()? just curious

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To no add an hard dependency.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you should check if stty is available at first?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nevermind.. the check is at linehttps://github.com/symfony/symfony/pull/9811/files#diff-312c2e9ca43f41955ae78e8adf50fe49R102

Copy link

Member

Please make your new helper aware of the interactive mode of the console input, so that we don't have to check manually each time we use it in order to keep the--no-interaction flag working. Most fully interactive commands are not putting their interaction ininteract before the execution, but in the middle of the execution when they need it.
This issue was fixed for dialogHelper in#8452 (in a hacky way IMO as I don't find the InputAwareInterface that clean, but it was needed because of BC concerns). The QuestionHelper should take this constraint into account since its first released implementation

stof reviewed

Dec 18, 2013

View reviewed changes

src/Symfony/Component/Console/Question/Question.php Outdated

Copy link

Member

stofDec 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be namedgetAutocompleter

[Console] added a better way to ask questions to the user

1c73191

cordoval reviewed

Feb 11, 2014

View reviewed changes

src/Symfony/Component/Console/Helper/QuestionHelper.php

Copy link

Contributor

cordovalFeb 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

purposes

Copy link

Member

stof commentedMar 4, 2014

@fabpot what is the status on this PR ?

romainneutron mentioned this pull request

Apr 1, 2014

[Console] added a better way to ask questions to the user#10606

Merged

3 tasks

fabpot added a commit that referenced this pull request

Apr 2, 2014

feature#10606[Console] added a better way to ask questions to the u…

afc34cf

…ser (fabpot, romainneutron)This PR was merged into the 2.5-dev branch.Discussion----------[Console] added a better way to ask questions to the user| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | not yetThis PR replaces#9811- [x] add missing phpdocs- [x] add unit tests- [ ] submit doc PRCommits-------336bba2 [Console] Add docblocks and unit tests to QuestionHelperc413f89 [Console] added a better way to ask questions to the user