Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added tests for #8930#9764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
thunderer wants to merge2 commits intosymfony:2.3fromthunderer:issue8930
Closed

Conversation

@thunderer
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#8930
LicenseMIT
Doc PR-

These tests are for#8930 - I've refactored tests so that similar ones use@dataProvider annotation. From my experience with the subject this issue happens neither in 2.3 nor in master.

@cordoval
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fix indentation

@fabpot
Copy link
Member

Are you saying the the bug described in#8930 does not exit? Because I've just tried the script from this issue and indeed, there is an exception.

@cordoval
Copy link
Contributor

@fabpot i think he needs to close this since he has done a similar PR but for master.

@thunderer only one PR is needed,@fabpot can backtrace it. So please close this one, or the other. Usually is the case that we do bug fixes on the branch where the problem is reported and then@fabpot port this forward. Other projects like doctrine work differently where things are only fixed in the master and they are backtraced. Symfony however does things differently.

#9767

@thunderer
Copy link
ContributorAuthor

@cordoval Thanks for understanding what I've done, I simply didn't know how you handle such situation.

@fabpot Yes, I've tested that on my local machine (Ubuntu 12.04, PHP 5.4) and both sample script and tests passed without notice. I'll give it another chance on my main PC (same OS, PHP 5.5) and report changes. I'm curious - if Travis build didn't report anything is something wrong with my approach, test suite or something else?

@florianv
Copy link
Contributor

The issue only appears when using a dot. as path separator, that's why your tests are passing.

@fabpot
Copy link
Member

Closing in favor of#9843

@fabpotfabpot closed thisDec 23, 2013
@thundererthunderer deleted the issue8930 branchJuly 9, 2014 17:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thunderer@cordoval@fabpot@florianv

[8]ページ先頭

©2009-2025 Movatter.jp