NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Update Client.php#9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

parapety wants to merge1 commit intosymfony:masterfromparapety:master

Closed

Update Client.php#9762

parapety wants to merge1 commit intosymfony:masterfromparapety:master

Conversation

Copy link

parapety commentedDec 14, 2013

fix issue#9527

Update Client.php

08855cd

fix issuesymfony#9527

Copy link

Contributor

jakzal commentedDec 14, 2013

@parapety please update the description to follow thePR template.

Copy link

Contributor

cordoval commentedDec 14, 2013

you can also change the title to[BrowserKit] Update Client.php

Copy link

Member

stof commentedDec 16, 2013

Please add a test covering this bug, to avoid regressions

cordoval added a commit to cordoval/symfony that referenced this pull request

Dec 19, 2013

fixsymfony#9527for real, superceedssymfony#9762and adds test case…

42e50c7

… for overridding server paramters therby documenting correct behavior

cordoval mentioned this pull request

Dec 19, 2013

[BrowserKit | WCM] added override power to server parameters provided on request method#9821

Closed

Copy link

Contributor

cordoval commentedDec 19, 2013

@parapety even though your PR change did not get merge please keep trying to contribute. Your initial help ignited me to get the right fix. All was a team effort /o/, encouragements in all good there in Warszawa. I hope to visit again soon 👶

Copy link

Member

fabpot commentedDec 23, 2013

closing in favor of#9821

fabpot closed this

Dec 23, 2013

This was referencedDec 30, 2013

[BrowserKit] added override power to server parameters provided on request method#9901

Closed

[Filesystem] addressed == -> === suggestion#9906

Merged

fabpot mentioned this pull request

Mar 27, 2014

Fixed server values in BrowserKit#10549

Closed

fabpot added a commit that referenced this pull request

Mar 27, 2014

bug#10549Fixed server values in BrowserKit (fabpot)

0380d14

This PR was merged into the 2.3 branch.Discussion----------Fixed server values in BrowserKit| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#9527,#9762,#9821,#9901| License       | MIT| Doc PR        | n/aCommits-------65b9810 fixed too greedy replacementsd9cf28d fixed protocol-relative URLs289da16 added override power to server parameters provided on request method