Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Finder] Add GLOB_BRACE support in Finder::in() method#9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
brikou wants to merge1 commit intosymfony:masterfrombrikou:finder_glob_brace

Conversation

brikou
Copy link
Contributor

before

$finder->files()->in(['My/First/Directory','My/Second/Directory','My/Third/Directory',]);

after

$finder->files()->in('My/{First,Second,Third}/Directory');
QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets~
LicenseMIT
Doc PR~

@cordoval
Copy link
Contributor

and tests?

@jakzal
Copy link
Contributor

@brikou could you add some tests? Might be similar to the ones forthe GLOB_DIR.

@brikou
Copy link
ContributorAuthor

@jakzal@cordoval I'll add some test soon and then ping you back 👍

@cordoval
Copy link
Contributor

if you don't by next week then we will take it on hacking day 👶 sounds like a good test to write

@brikou
Copy link
ContributorAuthor

@cordoval really great if someone can works on it at the symfonycon...

@jakzal
Copy link
Contributor

Closing in favor of#9926 which includes a test case and a changelog update.

@jakzaljakzal closed thisJan 1, 2014
@brikou
Copy link
ContributorAuthor

@jakzal great! Thx

fabpot added a commit that referenced this pull requestJan 2, 2014
…d (jakzal)This PR was merged into the 2.5-dev branch.Discussion----------[Finder] Added GLOB_BRACE support in Finder::in() method| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#9705| License       | MIT| Doc PR        | ~**before**```php$finder->files()->in([    'My/First/Directory',    'My/Second/Directory',    'My/Third/Directory',]);```**after**```php$finder->files()->in('My/{First,Second,Third}/Directory');```Commits-------e2698fc [Finder] Included GLOB_BRACE support in the CHANGELOG.30814d3 [Finder] Added a test case for the GLOB_BRACE in Finder:in().da67f5d [Finder] Added GLOB_BRACE support in Finder::in() method
@piotrpasich
Copy link

@brikou I think it might be used with pipes, not commas

$finder->files()->in('My/{First|Second|Third}/Directory');

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@brikou@cordoval@jakzal@piotrpasich
[8]ページ先頭
©2009-2025 Movatter.jp