Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ExpressionLanguage] throw exception when parameters contain expressions#9700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.4fromaitboudad:patch-1
Dec 12, 2013

Conversation

aitboudad
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#9658
LicenseMIT
Doc PRsymfony/symfony-docs#3232

@mvrhov
Copy link

I already said that throwing the exception is the easy way, and I don't agree with that as it really doesn't solve the actual problem. If this cannot be solved otherwise I'd rather have getParameter returning null. And documentation explicitly stating that when parameters contain expression the getParameter function returns null for that specific parameter

@wouterj
Copy link
Member

@mvrhov why do you want to use expressions in parameters? If you want to do that, you should create the parameter in the Extension of the bundle

@mvrhov
Copy link

I said that in original ticket in my case that's for multitenat application Where some parameters are dependant on the tenant.

@stof
Copy link
Member

stof commentedDec 6, 2013

@mvrhov As parameters are resolved at compilation time and dumped statically, it won't work. You should use the expression in the argument instead of using it in a parameter.

@mvrhov
Copy link

I can't configure 3rd party bundles like this? Also the services that are configured via parameters.yml seem to work just fine, the only problem ATM is the parameters array. That's why my suggestion is to write null for those keys.

@mvrhov
Copy link

I've updated the original issue with additional information.

fabpot added a commit that referenced this pull requestDec 12, 2013
…n expressions (aitboudad)This PR was merged into the 2.4 branch.Discussion----------[ExpressionLanguage] throw exception when parameters contain expressions| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#9658| License       | MIT| Doc PR        |symfony/symfony-docs#3232Commits-------ca123bc [ExpressionLanguage] throw exception when parameters contain expressions
@fabpotfabpot merged commitca123bc intosymfony:2.4Dec 12, 2013
@aitboudadaitboudad deleted the patch-1 branchDecember 12, 2013 16:43
@jakzaljakzal mentioned this pull requestDec 8, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@aitboudad@mvrhov@wouterj@stof@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp