Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] fix #9325 extend table helper to have a row divider#9680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
woah! removing immediately
cordoval commentedDec 2, 2013
👍 |
wouterj commentedDec 2, 2013
You must create a doc pr before merging this. (let's be strict again about that topic) |
cordoval commentedDec 3, 2013
ok@wouterj i will work on it |
cordoval commentedDec 3, 2013
@wouterj done |
hhamon commentedDec 3, 2013
Maybe you could squash your commits to have only one relevant. |
cordoval commentedDec 3, 2013
@hhamon done |
cordoval commentedDec 31, 2013
bump@fabpot , all good or shall i rebase? |
cordoval commentedDec 31, 2013
@fabpot rebased |
cordoval commentedDec 31, 2013
now i want to cook that bot@fabbot-io
@fabpot ^^ This PR is 👍 |
fabpot commentedMar 3, 2014
Closing in favor of#10365 |
…bpot)This PR was merged into the 2.5-dev branch.Discussion----------[Console] deprecated TableHelper in favor of Table| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#9788,#9680,#9325| License | MIT| Doc PR |symfony/symfony-docs#3627This PR makes the Table helper stateless. It also adds a way to define global styles and to change/tweak existing styles easily.The second commit adds the possibility to add a separator anywhere in the table output.Commits-------21784ce [Console] make it possible to pass a style directly to Table::setStyle()14caaec [Console] added the possibility to insert a table separator anywhere in a table output39c495f [Console] deprecated TableHelper in favor of Table
This PR gives the ability to insert divider rows within a table.