Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console][ProgressHelper] Added estimated time and memory usage#9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍 |
| @@ -26,7 +26,7 @@ class ProgressHelper extends Helper | |||
| const FORMAT_VERBOSE = ' %current%/%max% [%bar%] %percent%% Elapsed: %elapsed%'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can add the memory indicator toFORMAT_VERBOSE.
Can you submit 2 different PRs for your 2 features instead of mixing the estimated time and the memory usage together ? |
Do you want memory usage in FORMAT_VERBOSE and estimated in FORMAT_VERBOSE ? |
@lsv the memory usage and the estimated time are 2 different features for the progress helper. So they should be in 2 separate PRs (which can be reviewed and merged separately) instead of being in a single PR (forcing us to accept both or none). |
Closing this is favor of the 2 other PRs |
see issue#9560
How to use it.
And the output will be something like this
The estimated is actually quite close to the time it took for my command (it took 5 min and 53 sec) - but of course it requires that all elements take the same time to execute.
The estimated time will be recalculated on each advance() (same time elapsed gets updated)
I havent quite figured out in which format the estimated should be in, so I only added it to FORMAT_VERBOSE_NOMAX, but should maybe be added to others as well?