NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time#9453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

egeloen wants to merge1 commit intosymfony:masterfromegeloen:f-datetime-invalid-message-propagation

Closed

[Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time#9453

egeloen wants to merge1 commit intosymfony:masterfromegeloen:f-datetime-invalid-message-propagation

Conversation

Copy link

egeloen commentedNov 6, 2013

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

This PR propagates theinvalid_message &invalid_message_parameters in the datetime form type to the date & time sub form types. It allows to have the good error message if you use something else than thesingle_widget widget.

I have looked theDateTimeTypeTest but I have not found tests related to this kind of propagation, so for now I have not added tests yet.

[Form][DateTime] Propagate invalid_message & invalid_message paramete…

e894327

…rs to date & time sub widgets

Copy link

Author

egeloen commentedNov 9, 2013

ping @bschussek

Copy link

Author

egeloen commentedNov 14, 2013

I just notice it has been removed inac69394 but I don't really get why?

Copy link

Author

egeloen commentedDec 28, 2013

ping @bschussek

Copy link

Author

egeloen commentedFeb 12, 2014

@webmozart I would really like to have feedback about this one :)

Copy link

Contributor

webmozart commentedSep 25, 2014

Thanks for your patience,@egeloen. I merged this into 2.3.

webmozart added a commit that referenced this pull request

Sep 25, 2014

bug#9453[Form][DateTime] Propagate invalid_message & invalid_messag…

1653ca5

…e_parameters to date & time (egeloen)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#9453).Discussion----------[Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -This PR propagates the `invalid_message` & `invalid_message_parameters` in the datetime form type to the date & time sub form types. It allows to have the good error message if you use something else than the `single_widget` widget.I have looked the `DateTimeTypeTest` but I have not found tests related to this kind of propagation, so for now I have not added tests yet.Commits-------ea4ae74 [Form][DateTime] Propagate invalid_message & invalid_message parameters to date & time sub widgets