Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Non-default XML namespaces not supported#9345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
sandermarechal commentedOct 19, 2013
I have started working on a PR that uses DOM instead of SimpleXML for the XmlFileLoader |
ContributorAuthor
sandermarechal commentedOct 20, 2013
These unittests have been included in#9350 |
ContributorAuthor
sandermarechal commentedOct 20, 2013
Oops. Shouldn't close this. It's still an open bug. |
Member
fabpot commentedMar 3, 2014
Closing as the commit is included in#9350 |
fabpot added a commit that referenced this pull requestApr 2, 2014
… namespace support (sandermarechal, romainneutron)This PR was merged into the 2.5-dev branch.Discussion----------[DependencyInjection] Use DOM instead of SimpleXML for namespace support| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#9345| License | MITThis PR replaces#9350Commits-------a3c60c8 [DependencyInjection] Deprecate SimpleXMLElement33c91f9 [DependencyInjection] Use DOM instead of SimpleXML for namespace support
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DIC is not able to parse XML configs where the container configuration is not the default namespaces. Such configurations are used for example, in theDoctrineBundle test suite.
This PR adds a failing unittest for that case.
I have tried to fix the issue as well, but I didn't find a good way of fixing it without rewriting the entire XmlFileLoader using DOM instead of SimpleXML. Hence I am just submitting the test case, in the hope that someone smarter than me can fix this issue.