Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Split the component into 3 sub-components Core, ACL, HTTP#9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
webmozart wants to merge1 commit intosymfony:masterfromwebmozart:security-split

Conversation

@webmozart
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

The rationale behind this PR is to be able to use any of the sub components without requiring all the dependencies of the other sub components. Specifically, I'd like to use the core utils for an improved CSRF protection mechanism (#6554).

TODO:

  • Decide what to do with the resources
  • Improve the text of the README files in the sub-components (@schmittjoh could you do this?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

put the LICENSE under a meta folder according to best practices

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nope, that's only for bundles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh ok sorry did not know, pardon me sil vou plait 👶

@fabpot
Copy link
Member

I'm definitely in favor of this split... if we can do it without BC breaks... so the old class names must still exist.

By the way, I think it would make#8848 obsolete.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

same here --dev

@webmozart
Copy link
ContributorAuthor

@fabpot The only class names that were changed so far are the tests, where the namespaces changed fromSymfony\Component\Security\Tests\{Core|Acl|Http} toSymfony\Component\Security\{Core|Acl|Http}\Tests. I don't think the tests are part of our public API though.

I'm not quite sure what to do about theResources directory. We could just leave it where it is, meaning you need to installsymfony/security if you want to use the resources. Moving them would be a BC break.

@stof
Copy link
Member

@fabpot There is no BC breaks. Only test classes are renamed in this PR. All other classes are still the same.

for the resources, I think we should find a way to have them in one of the components. Having to require thesymfony/security component to get them kind of defeats the possibility to avoid installing the ACL system.

@webmozart
Copy link
ContributorAuthor

@stof Well one possibility would be to move them to wherever they belong (Core or HTTP?), and to add a Composer post-install hook that copies them to the main directory insymfony/security.

@fabpot
Copy link
Member

I suppose that the goal is to move the classes themselves as well, right?

@stof
Copy link
Member

@bschussek a post-install hook is not a good BC layer as it has to be added by the user in the root composer.json

@stof
Copy link
Member

@fabpot The Security component is already divided in 3 distinct namespaces. This PR simply creates the subtree splits of these 3 folders.

@fabpot
Copy link
Member

... I need to sleep more ;)

@fabpot
Copy link
Member

For the Resources directory, I wouldcopy to Core (as Http depends on Core), deprecate the old location, and remove it in 3.0. In the meantime, we must ensure that both Resources directory are kept in sync.

@fabpot
Copy link
Member

Closing in favor of#9064

@fabpotfabpot closed thisSep 18, 2013
fabpot added a commit that referenced this pull requestSep 18, 2013
This PR was merged into the master branch.Discussion----------[Security] Split the component into 3 sub-components Core, ACL, HTTP| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#9047,#8848| License       | MIT| Doc PR        | -The rationale behind this PR is to be able to use any of the sub components without requiring all the dependencies of the other sub components. Specifically, I'd like to use the core utils for an improved CSRF protection mechanism (#6554).Commits-------14e9f46 [Security] removed unneeded hard dependencies in Core5dbec8a [Security] fixed README files62bda79 [Security] copied the Resources/ directory to Core/Resources/7826781 [Security] Split the component into 3 sub-components Core, ACL, HTTP
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@webmozart@fabpot@stof@cordoval

[8]ページ先頭

©2009-2025 Movatter.jp