Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[2.2][Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted#8980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e they don't offer any performance benefit
…choices are submitted
Merged
3 tasks
fabpot added a commit that referenced this pull requestSep 10, 2013
This PR was merged into the 2.2 branch.Discussion----------[2.2][Form] Fixed expanded choice field to be marked invalid when unknown choices are submittedSame as#7940, rebased onto 2.2.Commits-------4d2dc55 [DoctrineBridge] Improved test coverage of EntityChoiceList9d3628c [Form] Improved test coverage of ChoiceList classesed83752 [Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted30aa1de [Form] Fixed ChoiceList::get*By*() methods to preserve order and array keys53f292a [Form] Removed usage of the ChoiceList::getIndicesFor*() methods where they don't offer any performance benefit
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as#7940, rebased onto 2.2.