Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] fix HInclude src (closes #8951)#8960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR was merged into the 2.2 branch.Discussion----------[HttpKernel] fix HInclude src (closes#8951)| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#8951| License | MIT| Doc PR | n/afixes a regression introduced in#8879Commits-------49f5027 [HttpKernel] fixer HInclude src (closes#8951)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why not something like substr(..., strlen($request->getSchemeAndHttpHost()))
Seems more safe and reliable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because the chars of scheme and host could possible be in the path as well, replacing them there by accident as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right, done indc762e1
fixes a regression introduced in#8879