Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Fragment handler call set request instead of using listener#8701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
mtotheikle wants to merge2 commits intosymfony:masterfrommtotheikle:fragment-handler-call-set-request-instead-of-using-listener
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e the context of a master request
These changes cannot be applied to 2.2 as the setRequest won't be called when the request changes. |
I figured as much but wanted to confirm. It did resolve my issue for the specific use case however I can see where it would break with the request changing. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 2 commits were made in fabpot/contagious-services which was in#7007. I think these changes need to be applied to the 2.2 branch as well since if they are not applied then you can not create a request in an event listener class and have fragments render from a view without getting the following error:
Undefined offset: 0 in .../src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.phpNot sure if this pull request can be applied without2ffcfb9 andec1e7ca but from my testing.