Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Test constants#8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In order to make more readable future diffs, expected values have beenindented.This means that if someone adds a new value at the end of the array, thediff will only print the new line with only the new addition, instead ofof deletion of the whole array and addition with the whole array withthe new value.
Added a test with a fixture for parameters with 'constant' as type.
Taking int account @fabpto's comments:*gnugat-forks@f9463da#commitcomment-3784007*gnugat-forks@f9463da#commitcomment-3784010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not what I had in mind. I was thinking about adding a comma at the end of the line:array('foo', 'bar'),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh I see, I totally missed these two. I just fixed it, if it's alright with you I'll squash the last two commits into the first one. Or I could squash everything into one commit.
Added a test for constant support in XML configuration files.
Related PR:#8661