Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] fixed issue where x509 authentication clears unrelated tokens#8528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… tokensThis commit fixes an issue where authentication listeners clear all security tokens in case of authentication failure.This behavior makes it impossible to combine certain authentication mechanisms, notably x509 with form-based login.
fabpot added a commit that referenced this pull requestJul 20, 2013
This PR was merged into the 2.2 branch.Discussion----------[Security] fixed issue where x509 authentication clears unrelated tokens| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#8226| License | MIT| Doc PR |symfony/symfony-docs#2825| Notes | Replaces PR#8283TODO:- [x] Feedback on change to make sure security is not affected- [x] Fix other authentication listeners (they suffer the same problem)- [x] Write unit tests for bug and maybe a few listener classes as wellThis pull request is the summary of the problem mentioned in the ticket above.It only fixes the "disappearing token" problem for one authentication provider, not all. If acceptable, the change needs to be applied to all authentication listeners since they always clear all tokens from the security context.Commits-------2317443 [Security] fixed issue where authentication listeners clear unrelated tokens
Member
weaverryan commentedJul 20, 2013
For future reference - the docs PR is actually#2835 :) |
Member
xabbuh commentedJul 22, 2013
Well, actuallysymfony/symfony-docs#2835 :) |
ContributorAuthor
alcaeus commentedJul 22, 2013
Whoopsie. Thanks guys, fixed it at the top info. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
This pull request is the summary of the problem mentioned in the ticket above.
It only fixes the "disappearing token" problem for one authentication provider, not all. If acceptable, the change needs to be applied to all authentication listeners since they always clear all tokens from the security context.