Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Swiftmailer spool collector#84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
A great thing would be to have a DataCollector showing the email sent as it would be easier to debug the mailing. Your implementation is not good as it does not collect the data about the current request. The spooled messages can concern another request. |
Mmm ok I see, so you are saying that showing spooled messages is not required but you prefer to have the webprofiler showing the current email sent ? |
Yes. The profiler is about collecting data on the current request:http://docs.symfony-reloaded.org/master/guides/internals/profiler.html so a Swiftmailer DataCollector should respect this design. But showing the email sent can be more difficult. I don't know if Swiftmailer provide an extension point to log the email sent (which would allow to collect them by logging in an array just like Doctrine and the Logger do for the profiler). |
I'm closing this PR as the current implementation cannot be merged as is. |
…ndre)This PR was merged into the master branch.Discussion----------Added Brazilian Portuguese translationsHi!Here is a complete Brazilian Portuguese translationCommits-------233ade0 Added Brazilian Portuguese translations
…sories#12-yaml-syntax-fixesCorrecting YAML syntax for branch names
…ersion (iluuu1994)This PR was merged into the 2.0-dev branch.Discussion----------Fix BinaryFileResponse with range to psr response conversionClosessymfony#84As requested by [Fabien](symfony#38280 (comment)).I think using the slightly less optimal version of checking for a `Content-Range` header is better than relying on reflection. In theory, this could be slightly sub optimal when streaming whole files and setting the `Content-Range` manually but I'm assuming that's very rare in practice.Commits-------5d5932d Fix BinaryFileResponse with range to psr response conversion
Increase minimum version minor version of PHPUnit version 5
This commit add a DataCollector for Swiftmailer spool with the number of messages in the spool.
I choose an icon in iconfinder.com, if you have a better one :)