Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Added missing column to the form's table layout#8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@webmozart
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

@stloyd
Copy link
Contributor

@bschussekSymfony/Bundle/FrameworkBundle/Resources/views/FormTable/button_row.html.php should be changed too, and test:Symfony/Component/Form/Tests/AbstractTableLayoutTest.php

@webmozart
Copy link
ContributorAuthor

@stloyd Why?

@stloyd
Copy link
Contributor

@bschussek Check:#8043 &#8053.

@webmozartwebmozart mentioned this pull requestMay 16, 2013
@webmozart
Copy link
ContributorAuthor

Both#8043 and#8053 were wrong. The PHP template and the test are fine. :)

@stloyd
Copy link
Contributor

@bschussek This should go to2.3 probably as#8043 is there =)

@webmozart
Copy link
ContributorAuthor

Ah, I didn't see that branch exists yet.@fabpot do you need a new PR?

fabpot added a commit that referenced this pull requestMay 16, 2013
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8059).Discussion----------[TwigBridge] Added missing column to the form's table layout| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------97f3669 [TwigBridge] Added missing column to the form's table layout
@fabpot
Copy link
Member

@bschussek no need to create another, I can switch the branch on my side easily.

@fabpotfabpot closed thisMay 16, 2013
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@webmozart@stloyd@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp