Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] Fixed the Crawler::html() method for early PHP versions#8013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…r than 5.3.6.Node argument was added to the DOMDocument::saveHTML() in PHP 5.3.6. Seehttp://php.net/manual/en/domdocument.savehtml.php.
fabpot added a commit that referenced this pull requestMay 13, 2013
This PR was merged into the master branch.Discussion----------[DomCrawler] Fixed the Crawler::html() method for early PHP versions| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes, but not on travis (segfault)| Fixed tickets |#7963| License | MIT| Doc PR | -Node argument was added to the [`DOMDocument::saveHTML()`](http://php.net/manual/en/domdocument.savehtml.php) in PHP 5.3.6. Seehttp://php.net/manual/en/domdocument.savehtml.php.It's not a nice looking solution, but seems to be the only option. Condition should be removed once PHP dependency goes over 5.3.6.Commits-------a4e3ebf [DomCrawler] Fixed the Crawler::html() method for PHP versions earlier than 5.3.6.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node argument was added to the
DOMDocument::saveHTML()in PHP 5.3.6. Seehttp://php.net/manual/en/domdocument.savehtml.php.It's not a nice looking solution, but seems to be the only option. Condition should be removed once PHP dependency goes over 5.3.6.