Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP][FrameworkBundle] Use new table helper in container:debug command#8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Burgov
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

This PR updates the container:debug command in order to make use of the new Table output helper. This should make the code cleaner and easer to maintain in the future. There are some issues which probably should be discussed before continuing/merging:

  • The layout breaks badly if the table doesn't fit into the console. For the normal services dump this won't occur so quickly, but when I tried to apply this on the --parameters command, it became unreadable
  • The layout breaks if you use (or other) tags. The helper will take the chars in account, while they are not rendered. I stripped them for now
  • I wanted to apply the helper on the service information view, but i think it won't be applicable... E.g.app/console container:debug data_collector.router.

Let me know what you think about the issues

@fabpot
Copy link
Member

Closing as it was done in#8451

@fabpotfabpot closed thisOct 1, 2013
@Burgov
Copy link
ContributorAuthor

@fabpot Maybe I'm overlooking something, but I don't really see how these two PR's are related?

@fabpot
Copy link
Member

Oops, the good PR is#7887. Unfortunately, I've just discovered that the PR is totally broken, so I'm working on fixing it now: see#9195.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Burgov@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp