Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Form] Added radio button for empty value to expanded single-choice fields#7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
webmozart commentedMay 5, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #3154 |
| License | MIT |
| Doc PR | symfony/symfony-docs#2605 |
| * @param array $choices An array of choices. Not existing choices in this | ||
| * array are ignored. | ||
| * | ||
| * @return array An array of indices with ascending, 0-based numeric keys | ||
| * @return array An array of indices with ascending, 0-based numeric keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we don't put dots at the end of the @... lines
Will this be backported? |
@rdohms This would change existing applications. I don't think we can backport this without breaking something. |
This PR was merged into the master branch.Discussion----------[Form] Added radio button for empty value to expanded single-choice fields| Q | A| ------------- | ---| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#3154| License | MIT| Doc PR |symfony/symfony-docs#2605Commits-------7933971 [Form] Added radio button for empty value to expanded single-choice fields
@bschussek not really, does this not kick in only if the or is there more to it? |
Really depends on the added complexity. But you can look at it as being a new feature or a bug fix; in the past, for similar cases, we always opted to consider such things as new features instead of bug fixes. |
@bschussek understood. I only ask because we have an internal ticket tied to this, so i need to understand what timeframes i can deal with. Backporting would allow me to roll out a fix now, 2.3 will require we wait a bit. No problem. |
@rdohms Ok, I'd prefer to wait then. Thank you for your patience! |
This PR was merged into the master branch.Discussion----------[Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted#7939 must be merged before this PR is merged.| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#5113,#5190| License | MIT| Doc PR | -TODO:- [x] test EntityChoiceList for stricter rules- [ ] test ModelChoiceList for stricter rules- [x] remove/deprecate the ChoiceList::getIndicesFor*() methodsCommits-------9efdb8e [Form] Deprecated ChoiceList::getIndicesFor*() methods67ba131 [DoctrineBridge] Improved test coverage of EntityChoiceList31e5ce5 [Form] Improved test coverage of ChoiceList classes6283b0e [Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted79a214f [Form] Fixed ChoiceList::get*By*() methods to preserve order and array keys62fbed6 [Form] Removed usage of the ChoiceList::getIndicesFor*() methods where they don't offer any performance benefit