Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()#7736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
webmozart commentedApr 20, 2013
I will adapt the documentation PRsymfony/symfony-docs#2092 once it is decided that this will be merged. |
webmozart referenced this pull request in symfony/symfony-docsApr 21, 2013
fabpot added a commit that referenced this pull requestApr 23, 2013
This PR was merged into the master branch.Discussion----------[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes (*)| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#5493| License | MIT| Doc PR | TODOThis change was discussed for a while in#5493. **(*)** It breaks BC *only for people who implemented* `FormInterface` *manually* (not a lot, so I hope). These can fix the problem by simply renaming `bind()` and `isBound()` in their implementation to `submit()` and `isSubmitted()`.The main rationale is that with the request handlers introduced in#6522, people won't be confronted with the term "binding" anymore. As such, `isBound()` will be a very strange name to new users that have never used `bind()` manually.See this code sample as example:```php$form = $this->createForm(...);$form->handleRequest($request);// Imagine you have never heard about bind() or binding. What does this mean?if ($form->isBound()) { // ...}```In reality, `bind()` submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:```php$form = $this->createForm(...);$form->handleRequest($request);// Aha!if ($form->isSubmitted()) { // ...}```Also when using `submit()` directly, the code makes much more sense now:```php$text = $this->createForm('text');$text->submit('New Value');```For current users, the current naming will be supported until 3.0.Commits-------41b0127 [Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was discussed for a while in#5493.(*) It breaks BConly for people who implemented
FormInterfacemanually (not a lot, so I hope). These can fix the problem by simply renamingbind()andisBound()in their implementation tosubmit()andisSubmitted().The main rationale is that with the request handlers introduced in#6522, people won't be confronted with the term "binding" anymore. As such,
isBound()will be a very strange name to new users that have never usedbind()manually.See this code sample as example:
In reality,
bind()submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:Also when using
submit()directly, the code makes much more sense now:For current users, the current naming will be supported until 3.0.