Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()#7736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromwebmozart:rename-bind
Apr 23, 2013

Conversation

@webmozart
Copy link
Contributor

QA
Bug fix?no
New feature?no
BC breaks?yes (*)
Deprecations?yes
Tests pass?yes
Fixed tickets#5493
LicenseMIT
Doc PRTODO

This change was discussed for a while in#5493.(*) It breaks BConly for people who implementedFormInterfacemanually (not a lot, so I hope). These can fix the problem by simply renamingbind() andisBound() in their implementation tosubmit() andisSubmitted().

The main rationale is that with the request handlers introduced in#6522, people won't be confronted with the term "binding" anymore. As such,isBound() will be a very strange name to new users that have never usedbind() manually.

See this code sample as example:

$form =$this->createForm(...);$form->handleRequest($request);// Imagine you have never heard about bind() or binding. What does this mean?if ($form->isBound()) {// ...}

In reality,bind() submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:

$form =$this->createForm(...);$form->handleRequest($request);// Aha!if ($form->isSubmitted()) {// ...}

Also when usingsubmit() directly, the code makes much more sense now:

$text =$this->createForm('text');$text->submit('New Value');

For current users, the current naming will be supported until 3.0.

@webmozart
Copy link
ContributorAuthor

I will adapt the documentation PRsymfony/symfony-docs#2092 once it is decided that this will be merged.

webmozart referenced this pull request in symfony/symfony-docsApr 21, 2013
fabpot added a commit that referenced this pull requestApr 23, 2013
This PR was merged into the master branch.Discussion----------[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | yes (*)| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#5493| License       | MIT| Doc PR        | TODOThis change was discussed for a while in#5493. **(*)** It breaks BC *only for people who implemented* `FormInterface` *manually* (not a lot, so I hope). These can fix the problem by simply renaming `bind()` and `isBound()` in their implementation to `submit()` and `isSubmitted()`.The main rationale is that with the request handlers introduced in#6522, people won't be confronted with the term "binding" anymore. As such, `isBound()` will be a very strange name to new users that have never used `bind()` manually.See this code sample as example:```php$form = $this->createForm(...);$form->handleRequest($request);// Imagine you have never heard about bind() or binding. What does this mean?if ($form->isBound()) {    // ...}```In reality, `bind()` submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:```php$form = $this->createForm(...);$form->handleRequest($request);// Aha!if ($form->isSubmitted()) {    // ...}```Also when using `submit()` directly, the code makes much more sense now:```php$text = $this->createForm('text');$text->submit('New Value');```For current users, the current naming will be supported until 3.0.Commits-------41b0127 [Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()
@fabpotfabpot merged commit41b0127 intosymfony:masterApr 23, 2013
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webmozart@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp