Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Renamed form processors to request handlers#7732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
webmozart commentedApr 20, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | symfony/symfony-docs#2092 |
Member
fabpot commentedApr 20, 2013
Can you explain the rationale behind this change? |
ContributorAuthor
webmozart commentedApr 20, 2013
Mainly code readability. "Processing" a form is very ambiguous, while handling a request should explain better what happens under the hood. Example 1 (without HttpFoundation):$form =$formFactory->createForm(...);$form->handleRequest();if ($form->isValid()) {// ...} vs. $form =$formFactory->createForm(...);$form->process();if ($form->isValid()) {// ...} Example 2 (with HttpFoundation):$form =$formFactory->createForm(...);$form->handleRequest($request);if ($form->isValid()) {// ...} vs. $form =$formFactory->createForm(...);$form->process($request);if ($form->isValid()) {// ...} |
fabpot added a commit that referenced this pull requestApr 20, 2013
This PR was merged into the master branch.Discussion----------[Form] Renamed form processors to request handlers| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#2092Commits-------ae7c378 [Form] Renamed form processors to request handlers
nicolas-grekas added a commit that referenced this pull requestNov 21, 2017
…r` private variable to `::$nativeRequestHandler` (issei-m)This PR was merged into the 2.7 branch.Discussion----------[Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`| Q | A| ------------- | ---| Branch? |2.7| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | Not confirmed, but the changes are completely minor| Fixed tickets | -| License | MIT| Doc PR | -I guess the term "processor" had been used until [this PR comes](#7732), but hadn't been renamed properly at the time.And I think "handler" sounds more relevant to me anyway.Commits-------a35d4f8 [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.