Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[WIP][2.3][FrameworkBundle][Templating] Generate assets with absolute url#7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
c488d5c Added boilerplate code for generating absolute url assets
inoryyda3513a Added tests for AbsoluteUrlPackage
inoryy89c47e9 Implementation for AbsoluteUrlPackage::getUrl()
inoryyf76a244 Configure new AbsoluteUrlPackage & use it inside AssetsExtension
inoryy47f0f81 fixed CS
inoryyFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Added tests for AbsoluteUrlPackage
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitda3513a9b9c798060d48279f0f6d73d15ce58ae7
There are no files selected for viewing
55 changes: 55 additions & 0 deletionssrc/Symfony/Bundle/FrameworkBundle/Tests/Templating/Asset/AbsoluteUrlPackageTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?php | ||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
| namespace Symfony\Bundle\FrameworkBundle\Tests\Templating\Asset; | ||
| use Symfony\Component\Routing\RequestContext; | ||
| use Symfony\Bundle\FrameworkBundle\Templating\Asset\AbsoluteUrlPackage; | ||
| /** | ||
| * This package attempts to return absolute URL for assets | ||
| * | ||
| * @author Roman Marintšenko <roman.marintsenko@knplabs.com> | ||
| */ | ||
| class AbsoluteUrlPackageTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testGetUrl() | ||
| { | ||
| $package = new AbsoluteUrlPackage(new RequestContext()); | ||
| $this->assertEquals('http://example.com/foo.js', $package->getUrl('http://example.com/foo.js'), '->getUrl() does nothing if an absolute URL is already given'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('', 'GET', 'symfony.com')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. have you tried a dataprovider for this test? just wondering | ||
| $this->assertEquals('http://symfony.com/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends host and scheme to a given path'); | ||
| $this->assertEquals('http://symfony.com/foo.js', $package->getUrl('/foo.js'), '->getUrl() prepends host and scheme to a given absolute path'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('foo', 'GET', 'symfony.com')); | ||
| $this->assertEquals('http://symfony.com/foo/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends base url to relative path'); | ||
| $this->assertEquals('http://symfony.com/foo/foo.js', $package->getUrl('/foo.js'), '->getUrl() prepends base url to absolute path'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('/foo', 'GET', 'symfony.com')); | ||
| $this->assertEquals('http://symfony.com/foo/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends base url with backslash at beginning to relative path'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('foo/', 'GET', 'symfony.com')); | ||
| $this->assertEquals('http://symfony.com/foo/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends base url with backslash at end to relative path'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('', 'GET', 'symfony.com', 'http', 8080)); | ||
| $this->assertEquals('http://symfony.com:8080/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends port if it is different than 80'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('', 'GET', 'symfony.com', 'https', 80, 443)); | ||
| $this->assertEquals('https://symfony.com/foo.js', $package->getUrl('foo.js'), '->getUrl() does not prepend 443 port if scheme is https'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('', 'GET', 'symfony.com', 'https', 80, 444)); | ||
| $this->assertEquals('https://symfony.com:444/foo.js', $package->getUrl('foo.js'), '->getUrl() prepends port if scheme is https and it is different than 443'); | ||
| $package = new AbsoluteUrlPackage(new RequestContext('', 'GET', 'symfony.com'), 'abcd'); | ||
| $this->assertEquals('http://symfony.com/foo.js?abcd', $package->getUrl('foo.js'), '->getUrl() appends the version if defined'); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.