Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Input::__toString escaping fixes#7657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
Seldaek commentedApr 12, 2013
/cc@igorw |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Extract method forescapeToken?
Contributor
igorw commentedApr 12, 2013
👍 |
fabpot added a commit that referenced this pull requestApr 12, 2013
This PR was merged into the master branch.Discussion----------[Console] Input::__toString escaping fixesFollow up to#7648, also includes a fix for StringInput to parse newlines and other whitespace chars properly instead of normalizing them all to spaces. It was kinda needed to test it properly, so I bundled both in one.Commits-------93b1369 [Console] Fix StringInput parsing to accept newlines and tabs8642b67 [Console] Fix escaping of args
stof added a commit to stof/symfony that referenced this pull requestApr 13, 2013
The PRsymfony#7657 introduced a requirement on PHP 5.4 by mistake.
fabpot added a commit that referenced this pull requestApr 13, 2013
This PR was merged into the master branch.Discussion----------Fixed the Console code on PHP 5.3| Q | A| ------------- | ---| Fixed tickets | none (catched by the Travis builds)| License | MITThe PR#7657 introduced a requirement on PHP 5.4 by mistake.Commits-------1356050 Fixed the Console code on PHP 5.3
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to#7648, also includes a fix for StringInput to parse newlines and other whitespace chars properly instead of normalizing them all to spaces. It was kinda needed to test it properly, so I bundled both in one.