Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix constructor AbstractPreAuthenticatedListener#74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ractAuthenticationListener and make it compatible with caller in PreAuthenticatedAuthenticationProvider
Contributor
schmittjoh commentedFeb 22, 2011
Pre-authentication is fundamentally different from regular authentication. What is the benefit of this? |
Author
klaasn commentedFeb 22, 2011
it allows me to define the service easily CookieSecurityBundle\Security\CookieFactoryand class CookieProvider extends PreAuthenticatedAuthenticationProvider {} |
Author
klaasn commentedFeb 22, 2011
sorry, that made little sense. I meant to say that the service definition of the listener becomes the same for both. |
Contributor
schmittjoh commentedFeb 22, 2011
I still don't see why we need this, I'll close this pull request. |
SofHad pushed a commit to SofHad/symfony that referenced this pull requestOct 12, 2015
…bw, javiereguiluz)This PR was merged into the master branch.Discussion----------Add check.php file for access from webThis PR takes the work made by@bocharsky-bw insymfony#74 and applies the look-and-feel of the Symfony Demo application to better integrate it.### No errors - Before### No errors - After### Errors - Before### Errors - AfterCommits-------d88ef7b Added a note about in the README about the new requirements checked6972191 Minor change to allow sub-directory installation2295159 Add check.php file for access from web2128178 Add check.php file for access from web
jderusse pushed a commit to jderusse/symfony that referenced this pull requestMar 30, 2020
Add the advisory for ZF2015-05
chalasr pushed a commit to chalasr/symfony that referenced this pull requestSep 24, 2020
* Downgrade PHP requirements to PHP 7.1* Updated appveyor configuration* Addressed comments
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractPreAuthenticatedListener is only used in X509AuthenticationListener but there the constructor is overwritten.
It is a different from the constructor in
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
This change gives the two listeners the same footprint.