Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] fixes cahe:clear command's warmup#7360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $content = preg_replace('/'.preg_quote($warmupDir, '/').'/', preg_replace('/_new$/', '', $warmupDir), $content); | ||
| file_put_contents(preg_replace($regex, '', $file), $content); | ||
| $content = str_replace($this->getTempKernelSuffix(), '', file_get_contents($file)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isstr_replace better thanpreg_replace? I think it's more readable, but what about performances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
str_replace is considered faster
@toloco@gergelypolonkai@ghost-x47@stewe it would be great if you could test this patch on your projects and report result! |
toloco commentedMar 13, 2013
Im sorry but have the same... Notice: unserialize(): Error at offset 155 of 174227 bytes in /home/tolopalmer/Projects/shareandcoach/app/bootstrap.php.cache line 915 |
@toloco could you paste the backtrace in a gist? and maybe the concerned file? |
@jfsimon You probably have the same issue with the name of the temporary kernel class |
@stof if you're right, it's a nightmare. It must be possible to write a parser/fixer for serialized objects, don't you think? |
toloco commentedMar 13, 2013
Here you are the gist with the stack and the bootstrap.php.cache file |
@jfsimon Writing such a parser is painting yourself in the corner. Use a temp kernel class name of the same length as a quick fix. #7230 could bring a solution because we might be able to inject a different ConfigCache factory during the command that intercepts and substitutes Resources before they get written into the meta file. Not sure if that PR has a chance of being picked though. |
toloco commentedMar 14, 2013
So guys? we are blocked with this problem, can I help you? I can provide more stacks if it's needed |
@toloco Could you please post the /home/tolopalmer/Projects/shareandcoach/app/cache/dev/appDevUrlMatcher.php.meta file? That's the one that is broken. |
@mpdude you can find its content in the gisthttps://gist.github.com/toloco/5152581 (1st file, 6th line) |
@toloco That file should contain a serialized set of Resources, it's not in the Gist. |
@mpdude it's more visible in the raw file: ttps://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+ |
toloco commentedMar 14, 2013
https://gist.github.com/toloco/5160317 here you are the appDevUrlMatcher.php and meta |
toloco commentedMar 14, 2013
Man!!!! you are the fucking boss it works!! |
@jfsimon you just made someone happy. |
This PR was merged into the 2.1 branch.Commits-------f2ef6bc [FrameworkBundle] removed BC breakcc3a40e [FrameworkBundle] changed temp kernel name in cache:clear7d87ecd [FrameworkBundle] fixed cahe:clear command's warmupDiscussion----------[FrameworkBundle] fixes cahe:clear command's warmupSolution taken is to replace the last char of the cache directory name to create a temporary cache directory, this way the temporary cache path has the same length than the real one. I tested this on several projects, in dev and prod environments.| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets |#6203---------------------------------------------------------------------------by jfsimon at 2013-03-13T12:32:25Z@toloco@gergelypolonkai@ghost-x47@stewe it would be great if you could test this patch on your projects and report result!---------------------------------------------------------------------------by toloco at 2013-03-13T12:41:47ZIm sorry but have the same...Notice: unserialize(): Error at offset 155 of 174227 bytes in /home/tolopalmer/Projects/shareandcoach/app/bootstrap.php.cache line 915---------------------------------------------------------------------------by jfsimon at 2013-03-13T12:45:04Z@toloco could you paste the backtrace in a gist? and maybe the concerned file?---------------------------------------------------------------------------by stof at 2013-03-13T13:11:47Z@jfsimon You probably have the same issue with the name of the temporary kernel class---------------------------------------------------------------------------by jfsimon at 2013-03-13T13:36:13Z@stof if you're right, it's a nightmare. It must be possible to write a parser/fixer for serialized objects, don't you think?---------------------------------------------------------------------------by toloco at 2013-03-13T14:22:56ZHere you are the gist with the stack and the bootstrap.php.cache filehttps://gist.github.com/toloco/5152581---------------------------------------------------------------------------by mpdude at 2013-03-13T20:08:08Z@jfsimon Writing such a parser is painting yourself in the corner.Use a temp kernel class name of the same length as a quick fix.#7230 could bring a solution because we might be able to inject a different ConfigCache factory during the command that intercepts and substitutes Resources before they get written into the meta file. Not sure if that PR has a chance of being picked though.---------------------------------------------------------------------------by toloco at 2013-03-14T08:19:58ZSo guys? we are blocked with this problem, can I help you? I can provide more stacks if it's needed---------------------------------------------------------------------------by mpdude at 2013-03-14T10:05:05Z@toloco Could you please post the /home/tolopalmer/Projects/shareandcoach/app/cache/dev/appDevUrlMatcher.php.meta file? That's the one that is broken.---------------------------------------------------------------------------by jfsimon at 2013-03-14T10:15:20Z@mpdude you can find its content in the gisthttps://gist.github.com/toloco/5152581 (1st file, 6th line)---------------------------------------------------------------------------by mpdude at 2013-03-14T10:24:55Z@toloco That file should contain a serialized set of Resources, it's not in the Gist.---------------------------------------------------------------------------by jfsimon at 2013-03-14T10:33:12Z@mpdude it's more visible in the raw file: ttps://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+---------------------------------------------------------------------------by jfsimon at 2013-03-14T10:33:27Zsorry:https://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+---------------------------------------------------------------------------by toloco at 2013-03-14T10:37:09Zhttps://gist.github.com/toloco/5160317 here you are the appDevUrlMatcher.php and meta---------------------------------------------------------------------------by jfsimon at 2013-03-14T10:51:46Z@toloco I applied@mpdude's solution (have a temp kernel class name of the same length than the real one).Could you test it to see if it fixes your problem?---------------------------------------------------------------------------by mpdude at 2013-03-14T10:58:46Z@jfsimon Thanks!@toloco If Jean-François' fix does not work, please make sure that the .meta file you posted was the broken one? I was able to unserialize it without problems.---------------------------------------------------------------------------by toloco at 2013-03-14T11:02:09ZMan!!!! you are the fucking boss it works!!---------------------------------------------------------------------------by mpdude at 2013-03-14T11:04:30Z@jfsimon you just made someone happy.---------------------------------------------------------------------------by jfsimon at 2013-03-14T11:12:39Z@toloco@mpdude \o/
With this, I'm getting an error like Fatal error: Cannot redeclare class EnhancedProxy_118d51486383c6c253e028cf920e4439dd7c4e33__CG__\MyVendor\MyBundle\Controller\MyController in app/cache/de_/jms_diextra/proxies/MyVendor-MyBundle-Controller-MyController.php on line 28 when clearing my cache. |
I think I know what the problem is. The cache command is started with the current container and static Kernel class name. The most simple solution would be to the not use a static _, but single random character (not equal to the last char of the real kernel class) :) the length is still the same but its name is dynamic. @jfsimon can you test this theory? |
I tried making the last char random, still getting the error. |
What object does that proxy proxy? Which class does it extend? "Cannot redeclare class" rather sounds as if a proxy of the same name as an already used proxy was loaded... |
Is anyone even working on a fix? The current behavior is pretty annoying. It seems to me that there's no progress as noone feels responsible. |
skeud commentedJul 4, 2014
Is anyone working on fixing this issue? |
toloco commentedJul 4, 2014
Man it's closed, what do you think? |
skeud commentedJul 4, 2014
Sorry for the too fast copy/paste from the other issue linked to this one. I didn't checked/see that the issue was closed here. |
Solution taken is to replace the last char of the cache directory name to create a temporary cache directory, this way the temporary cache path has the same length than the real one. I tested this on several projects, in dev and prod environments.