Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] fixed locale management when exiting sub-requests#7099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -32,19 +33,24 @@ public function __construct($defaultLocale = 'en', RequestContextAwareInterface | |||
| $this->router = $router; | |||
| } | |||
| public function onKernelResponse($event) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
phpdoc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can $event be typhinted?
changelog ? |
The changelogs are updated when we release a new version only. |
@fabpot the intl locale should be reset to the right value too |
| ); | ||
| } | ||
| private function setLocale($request, $locale) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you should typehint the request
hmm sorry, I missed the fact that you are changing the locale in the Request again, which will set the intl one |
This fix is temporary assymfony#7007 will fix it properly in Symfony 2.3.
This PR was merged into the 2.1 branch.Commits-------3e40c17 [HttpKernel] fixed locale management when exiting sub-requestsDiscussion----------[HttpKernel] fixed locale management when exiting sub-requests| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#7063| License | MIT| Doc PR | n/aThis fix is temporary as#7007 will fix it properly in Symfony 2.3.---------------------------------------------------------------------------by vicb at 2013-02-17T20:17:44Zchangelog ?---------------------------------------------------------------------------by fabpot at 2013-02-17T20:27:22ZThe changelogs are updated when we release a new version only.---------------------------------------------------------------------------by stof at 2013-02-17T20:41:00Z@fabpot the intl locale should be reset to the right value too---------------------------------------------------------------------------by stof at 2013-02-17T20:42:31Zhmm sorry, I missed the fact that you are changing the locale in the Request again, which will set the intl one
This fix is temporary as#7007 will fix it properly in Symfony 2.3.