Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.3] removed deprecated methods from RouteCollection#7052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedMar 1, 2013
I've started a meta-PR to remove all deprecated stuff in 2.3. Can you split this PR into 2: one for 2.3 and another one for 2.2? Thanks. |
ContributorAuthor
Tobion commentedMar 1, 2013
@fabpot yes that was my plan |
ContributorAuthor
Tobion commentedMar 5, 2013
Member
fabpot commentedMar 6, 2013
#7266 has been merged and 2.2 has been merged into master. |
ContributorAuthor
Tobion commentedMar 6, 2013
@fabpot rebased. |
Member
fabpot commentedMar 6, 2013
Thanks, your commit is now part of#7227 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated things from the RouteCollection for Symfony 2.3.
It's a WIP because it also contains test fixes which are going in 2.2 instead. This way, there are no deprecated calls in 2.2.