Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.3] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle#6815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is no point for such method, that do nothing more than oneif check...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree
peterhorne commentedFeb 11, 2013
Thanks loalf! Any news on if / when this will be merged in? |
loalf commentedFeb 11, 2013
Thanks@peterhone. You better ask@fabpot or someone in the core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would make it disabled by default. So, it should becanbeenabled here.
loalf commentedMar 23, 2013
@fabpot changed |
This PR was merged into the master branch.Discussion----------[2.3] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework BundleThis PR is the same as#5347but since I am struggling to squash all the commits I better create a new one. Sorry for the inconveniences, :)Commits-------b4e4844 Add the serializer service
…e by default (dunglas)This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#12295).Discussion----------[FrameworkBundle] make GetSetMethodNormalizer available by default| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | very limited| Deprecations? | no| Tests pass? | yes| License | MIT| Doc PR | not yetThe `GetSetMethodNormalizer` has not been enabled by default in#6815 because it was broken by design. Since#12098 has been merged, circular references are handled and that normalizer cannot breaks applications.This PR makes that normalizer automatically available when the serializer is enabled. To keep BC, I've set a "high" priority for this service (higher than the default `0`).Commits-------4f0aa61 [FrameworkBundle] make GetSetMethodNormalizer available by default
This PR is the same as
#5347
but since I am struggling to squash all the commits I better create a new one. Sorry for the inconveniences, :)