Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] CardScheme improvements#6450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$schemes = array_flip((array) $constraint->schemes); would be shorter
Sgoettschkes commentedDec 21, 2012
True@stof! I changed this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code of the test is exactly the same than the previous one. Simply merge both data providers together
stloyd commentedJan 7, 2013
@Sgoettschkes Could you please squash those commits and give "better" message? i.e. |
Sgoettschkes commentedJan 7, 2013
Done. |
fabpot commentedJan 7, 2013
Closing in favor of#6583 |
Bug fix: yes
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -