Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.8k
Update SameOriginCsrfTokenManager.php#62826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:8.1
Are you sure you want to change the base?
Conversation
small typo fix1 & (1 << 8) or 1 & 256 is always equal to 0
carsonbot commentedDec 19, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedDec 19, 2025
Hey! Thanks for your PR. You are targeting branch "8.1" but it seems your PR description refers to branch "8.1 for features / 6.4, 7.3, 7.4, 8.0 for bug fixes". Cheers! Carsonbot |
llegaz commentedDec 19, 2025
@nicolas-grekas Hello Nicolas, great talk on AFUP PHP YouTube channel, I think I just found a lil typo in your stateless csrf validator |
Uh oh!
There was an error while loading.Please reload this page.
small typo fix
that is to say
is unfortunately always equal to 0
Best regards,
Laurent LEGAZ (http://laurent.legaz.eu)