Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update SameOriginCsrfTokenManager.php#62826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
llegaz wants to merge1 commit intosymfony:8.1
base:8.1
Choose a base branch
Loading
fromllegaz:patch-1

Conversation

@llegaz
Copy link

@llegazllegaz commentedDec 19, 2025
edited
Loading

small typo fix

1 & (1 <<8)

that is to say

1 &256

is unfortunately always equal to 0

Best regards,
Laurent LEGAZ (http://laurent.legaz.eu)

QA
Branch?7.X (I think since 7.2 when this Class was added)
Bug fix?yes
New feature?no
Deprecations?no
Issuesjust viewed Nicolas talk on AFUP YT channel
LicenseMIT

small typo fix1 & (1 << 8)  or 1 & 256 is always equal to 0
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleUpdate SameOriginCsrfTokenManager.php Update SameOriginCsrfTokenManager.phpDec 19, 2025
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "8.1" but it seems your PR description refers to branch "8.1 for features / 6.4, 7.3, 7.4, 8.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@llegaz
Copy link
Author

@nicolas-grekas Hello Nicolas, great talk on AFUP PHP YouTube channel, I think I just found a lil typo in your stateless csrf validator

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

2 participants

@llegaz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp