NotificationsYou must be signed in to change notification settings
Fork9.8k
Star30.9k

[Notifier][Prelude] Add bridge#62801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

zairigimad wants to merge1 commit intosymfony:8.1

base:8.1

Choose a base branch

fromzairigimad:feat/prelude-notifier-sms

Open

[Notifier][Prelude] Add bridge#62801

zairigimad wants to merge1 commit intosymfony:8.1fromzairigimad:feat/prelude-notifier-sms

+541 −0

Conversation

Copy link

Contributor

zairigimad commentedDec 17, 2025•
edited
Loading

Q	A
Branch?	8.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Recipe	symfony/recipes#1502
Issues	Fix#62802
License	MIT

This PR adds the support for Prelude Notification ( Prelude is a provider for OTP, Transactional SMS , and whatsapp messaging)

https://docs.prelude.so/introduction/welcome-to-prelude

zairigimad requested a review fromOskarStark as acode owner

December 17, 2025 13:30

carsonbot added Status: Needs Review Feature Notifier labels

Dec 17, 2025

carsonbot added this to the8.1 milestone

Dec 17, 2025

OskarStark changed the title~~[Notifier] Add Prelude Notifier for SMS~~[Notifier][Prelude] Add bridge

Dec 17, 2025

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/.gitattributes OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/CHANGELOG.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/CHANGELOG.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/LICENSE OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/README.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/Tests/PreludeTransportFactoryTest.php OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/composer.json OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Prelude/composer.json OutdatedShow resolvedHide resolved

OskarStark reviewed

Dec 17, 2025

View reviewed changes

Copy link

Contributor

OskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Leas update theUnsupportedSchemeException + you can prepare a recipe insymfony/recipes repository, thanks

zairigimad force-pushed thefeat/prelude-notifier-sms branch fromac3aed7 to25486e5Compare

December 17, 2025 13:43

Copy link

ContributorAuthor

zairigimad commentedDec 17, 2025

UnsupportedSchemeException

I did fix the majority of comments, for UnsupportedSchemeException what should i update ?

I will add the recipe asap

zairigimad force-pushed thefeat/prelude-notifier-sms branch 7 times, most recently from73600f2 to3232eb7Compare

December 17, 2025 15:26

add Prelude Notifier for SMS

e439429

zairigimad force-pushed thefeat/prelude-notifier-sms branch from3232eb7 toe439429Compare

December 17, 2025 15:34

zairigimad requested a review fromOskarStark

December 17, 2025 15:59

Copy link

ContributorAuthor

zairigimad commentedDec 17, 2025

Leas update theUnsupportedSchemeException + you can prepare a recipe insymfony/recipes repository, thanks

recipe done

nicolas-grekas reviewed

Dec 17, 2025

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cool, thanks for submitting!

src/Symfony/Component/Notifier/Bridge/Prelude/CHANGELOG.md

		8.1
		---

		* Add bridge

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	* Add bridge
	* Add bridge

src/Symfony/Component/Notifier/Bridge/Prelude/composer.json

Comment on lines +24 to +28

		"symfony/http-client": "^6.4\|^7.0\|^8.0",
		"symfony/notifier": "^7.3\|^8.0"
		},
		"require-dev": {
		"symfony/http-client": "^6.4\|^7.0\|^8.0"

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"symfony/http-client":"^6.4\|^7.0\|^8.0",
	"symfony/notifier":"^7.3\|^8.0"
	},
	"require-dev": {
	"symfony/http-client":"^6.4\|^7.0\|^8.0"
	"symfony/http-client":"^7.4\|^8.0",
	"symfony/notifier":"^7.4\|^8.0"

src/Symfony/Component/Notifier/Bridge/Prelude/phpunit.xml.dist

		<?xml version="1.0" encoding="UTF-8"?>

		<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
		xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/9.3/phpunit.xsd"

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

11.3 now - please borrow from other bridges from branch 8.1

src/Symfony/Component/Notifier/Bridge/Prelude/PreludeOptions.php

		private readonly ?string $scheduleAt = null,
		private readonly ?string $callbackUrl = null,
		private readonly ?string $correlationId = null,
		private readonly ?string $preferredChannel = null,

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We have quite some inconsistency in the way the various bridges define their options class.
The proposed one is very unlike the majority (eg things started with an $options argument and setters/getter without set/get prefixes.)
It's a bit inconsistent already, but let's define how we want to improve consistency? /cc@OskarStark

Labels

Feature Notifier Status: Needs Review

		"symfony/http-client": "^6.4\|^7.0\|^8.0",
		"symfony/notifier": "^7.3\|^8.0"
		},
		"require-dev": {
		"symfony/http-client": "^6.4\|^7.0\|^8.0"

	"symfony/http-client":"^6.4\|^7.0\|^8.0",
	"symfony/notifier":"^7.3\|^8.0"
	},
	"require-dev": {
	"symfony/http-client":"^6.4\|^7.0\|^8.0"
	"symfony/http-client":"^7.4\|^8.0",
	"symfony/notifier":"^7.4\|^8.0"

Movatterモバイル変換

Uh oh!

[Notifier][Prelude] Add bridge#62801

Are you sure you want to change the base?

[Notifier][Prelude] Add bridge#62801

Conversation

zairigimad commentedDec 17, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OskarStark left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zairigimad commentedDec 17, 2025

Uh oh!

zairigimad commentedDec 17, 2025

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasDec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasDec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasDec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasDec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zairigimad commentedDec 17, 2025•
edited
Loading

OskarStark left a comment•
edited
Loading