Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.8k
[FrameworkBundle] MakeConfigDebugCommand use its container to resolve env vars#62681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
MatTheCat wants to merge1 commit intosymfony:6.4Choose a base branch fromMatTheCat:ticket_62554
base:6.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
GromNaN requested changesDec 7, 2025
src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Member
GromNaN commentedDec 8, 2025
Is there a way to test this fix? |
ContributorAuthor
MatTheCat commentedDec 8, 2025
Couldn’t figure out how; looks like the issue also impact functional tests 😕 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The
ConfigDebugCommandcurrently cannot use theSodiumVaultto load env vars because its$secretsDirdepends on one, so calling it with--resolve-env-varsfails if an env var is only present in the vault. I’m not sure if it’s for the same reason but compiling the container with$resolveEnvPlaceholderssuffers from the same issue.I didn’t find a way to fix this so this PR works around it by setting the new container’s env var processors as the command’s so that the vault (and anything that could be used to resolve env vars) is correctly initialized.