Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Fixed some typos and syntax here and there for the greek language#62575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chris-nt wants to merge1 commit intosymfony:6.4
base:6.4
Choose a base branch
Loading
fromchris-nt:el-language-validator-fixes

Conversation

@chris-nt
Copy link

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
IssuesFix#57108
LicenseMIT

Fixed some typos and syntax here and there. Also I improved the grammar

Fixed some typos and syntax here and there. Also I improved the grammar
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR improves Greek language translations in the Symfony Validator component by correcting typos, improving grammar, and enhancing overall translation quality. The changes focus on making the Greek translations more natural, grammatically correct, and consistent throughout the file.

Key changes:

  • Grammar improvements: Changed "θα έπρεπε" (should have) to "πρέπει" (must) for more direct/authoritative tone
  • Terminology updates: Replaced informal terms like "ανέβηκε" (uploaded colloquially) with formal "μεταφορτώθηκε" (uploaded formally)
  • Consistency fixes: Improved pronoun usage and sentence structure for better readability

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

<trans-unitid="13">
<source>This value is not a valid email address.</source>
<target>Ητιμή δεν αντιστοιχεί σεέγκυρο email.</target>
<target>Αυτή ητιμή δεν αντιστοιχεί σεέγκυρη διεύθυνση ηλεκτρονικου ταχυδρομίου.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Corrected spelling of 'ηλεκτρονικου' to 'ηλεκτρονικού' (missing accent on 'ου').

Suggested change
<target>Αυτή η τιμή δεν αντιστοιχεί σε έγκυρη διεύθυνσηηλεκτρονικου ταχυδρομίου.</target>
<target>Αυτή η τιμή δεν αντιστοιχεί σε έγκυρη διεύθυνσηηλεκτρονικού ταχυδρομίου.</target>

Copilot uses AI. Check for mistakes.
<trans-unitid="62">
<source>This value is neither a valid ISBN-10 nor a valid ISBN-13.</source>
<target>Αυτό δεν είναι ούτε έγκυρος κωδικός ISBN-10 ούτε έγκυρος κωδικός ISBN-13.</target>
<target>Αυτός δεν είναι έγκυρος κωδικός ISBN-10 ούτε έγκυρος κωδικός ISBN-13.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[nitpick] Added missing article 'ούτε' should be 'ούτε ένας' for grammatical correctness, but the current correction is incomplete - should read 'Αυτός δεν είναι ούτε έγκυρος κωδικός ISBN-10 ούτε έγκυρος κωδικός ISBN-13' (missing 'ένας' after first 'ούτε').

Suggested change
<target>Αυτός δεν είναι έγκυρος κωδικός ISBN-10 ούτε έγκυρος κωδικός ISBN-13.</target>
<target>Αυτός δεν είναιούτε έναςέγκυρος κωδικός ISBN-10 ούτε έγκυρος κωδικός ISBN-13.</target>

Copilot uses AI. Check for mistakes.
<trans-unitid="134">
<source>The video is portrait oriented ({{ width }}x{{ height }}px). Portrait oriented videos are not allowed.</source>
<targetstate="needs-review-translation">Το βίντεο είναι σεκατακόρυφο προσανατολισμό ({{ width }}x{{ height }}px). Βίντεο κάθετου προσανατολισμού δεν επιτρέπονται.</target>
<targetstate="needs-review-translation">Το βίντεο είναι σεκάθετου προσανατολισμό ({{ width }}x{{ height }}px). Βίντεο κάθετου προσανατολισμού δεν επιτρέπονται.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Grammar error: 'κάθετου προσανατολισμό' mixes genitive case ('κάθετου') with accusative case ('προσανατολισμό'). Should be either 'κάθετο προσανατολισμό' (accusative) or restructured.

Suggested change
<targetstate="needs-review-translation">Το βίντεο είναι σεκάθετου προσανατολισμό ({{ width }}x{{ height }}px). Βίντεο κάθετου προσανατολισμού δεν επιτρέπονται.</target>
<targetstate="needs-review-translation">Το βίντεο είναι σεκάθετο προσανατολισμό ({{ width }}x{{ height }}px). Βίντεο κάθετου προσανατολισμού δεν επιτρέπονται.</target>

Copilot uses AI. Check for mistakes.
@GromNaN
Copy link
Member

Hi@chris-nt, thank you very much for working on the translation. I asked copilot to review your changes, could you check its suggestions and accept/reject?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-nt@carsonbot@GromNaN

[8]ページ先頭

©2009-2025 Movatter.jp