Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.8k
Migrate the Security Bundle console commands to use the new invokable feature#62573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Migrate the Security Bundle console commands to use the new invokable feature#62573
Conversation
xabbuh commentedNov 29, 2025
I am not sure that we really want to do that as it calls for conflicts when merging |
707df92 tof663eb8Compare| --- | ||
| * Add support for the`clientHints`,`prefetchCache`, and`prerenderCache``ClearSite-Data` directives | ||
| * Migrate the`Symfony/Bundle/SecurityBundle/Command/DebugFirewallCommand` and`Symfony/Bundle/SecurityBundle/Command/SecurityRoleHierarchyDumpCommand` to the invokable console commands feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think it needs to be documented in the CHANGELOG as there are no consequences for the consumers of these commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright, the line has been removed
wouterj commentedNov 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for proposing this "modernization" :) However, I don't think we can do this given ourbackwards compatibility promise unfortunately. Given these classes aren't internal, we must make sure they remain ancestors of the So I don't think we can do anything here, and all existing commands in Symfony must keep using the |
derrabus commentedNov 30, 2025
I agree with@wouterj. It's a BC break which we don't gain much from. I don't believe we should do this. |
nicolas-grekas commentedNov 30, 2025
Thanks for proposing though. |
This PR migrates the Console Commands present in the Security Bundle to use the new invokable command feature introduced in Symfony 7.3.
This PR is targeting the Symfony 8.1 branch as it is removing the
extends Commandsyntax and public API.