NotificationsYou must be signed in to change notification settings
Fork9.8k
Star30.8k

[DependencyInjection] Don't add empty`.container.known_envs` in XML loader#62558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

GromNaN wants to merge1 commit intosymfony:7.4

base:7.4

Choose a base branch

fromGromNaN:di-known-env

Open

[DependencyInjection] Don't add empty`.container.known_envs` in XML loader#62558

GromNaN wants to merge1 commit intosymfony:7.4fromGromNaN:di-known-env

+2 −5

Conversation

Copy link

Member

GromNaN commentedNov 28, 2025•
edited
Loading

Q	A
Branch?	7.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

The XML loader is the only one that creates the.container.known_envs parameter even if there is no<when env="..."> in the file. The PHP and Yaml loaders read and update this parameter only when they find awhen@<env> key.

symfony/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php

Lines 81 to 85 in1aa580f

	if (str_starts_with($namespace,'when@')) {
	$knownEnvs =$this->container->hasParameter('.container.known_envs') ?array_flip($this->container->getParameter('.container.known_envs')) : [];
	$this->container->setParameter('.container.known_envs',array_keys($knownEnvs + [substr($namespace,5) =>true]));
	continue;
	}

symfony/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

Lines 958 to 962 in1aa580f

	if (str_starts_with($namespace,'when@')) {
	$knownEnvs =$this->container->hasParameter('.container.known_envs') ?array_flip($this->container->getParameter('.container.known_envs')) : [];
	$this->container->setParameter('.container.known_envs',array_keys($knownEnvs + [substr($namespace,5) =>true]));
	continue;
	}

This is causing an issue insymfony-config-xml-to-php when comparing the result of loading equivalent PHP and XML config files. This key is added by the XML loader, not the PHP loader.

carsonbot added Status: Needs Review Bug DependencyInjection labels

Nov 28, 2025

carsonbot added this to the7.4 milestone

Nov 28, 2025

carsonbot changed the title~~[DependencyInjection] Don't add.container.known_envs when empty~~[DependencyInjection] Don't add.container.known_envs when empty

Nov 28, 2025

GromNaN changed the title~~[DependencyInjection] Don't add.container.known_envs when empty~~[DependencyInjection] Don't add.container.known_envs when empty in XML loader

Nov 28, 2025

[DependencyInjection] Don't add the .container.known_envs parameter w…

c3fa63b

…hen emptyOther loaders does not create this parameter when there is no when@<env> key

GromNaN force-pushed thedi-known-env branch from20dd42a toc3fa63bCompare

November 28, 2025 21:20

GromNaN changed the title~~[DependencyInjection] Don't add.container.known_envs when empty in XML loader~~[DependencyInjection] Don't add empty.container.known_envs in XML loader

Nov 28, 2025