Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.8k
[DependencyInjection] Ensure deprecation detection does not trigger a PHP error#62544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bnf wants to merge1 commit intosymfony:7.4Choose a base branch
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+35 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedNov 28, 2025
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
7fccf18 toe74ddd9Compared7e7fab toea76884Compare… PHP errorThe `class_exists` check and the condition `$definition instanceof ChildDefinition`have been swapped withsymfony#61215 in order to produce an error if a service is notavailable.This error was later relaxed to a deprecation insymfony#61270, but the executing orderof the condition kept to be `class_exists` first, then `instanceof`.That means, if `class_exists` fails with a PHP error(like PHP Fatal Error: Interface "My\Vendor\MyInterface" not found`)affected uses will not receive the deprecation, but a fatal error instead.
ea76884 to31de844CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Exception Interface "TYPO3\CMS\Reports\StatusProviderInterface" not foundSeehttps://forge.typo3.org/issues/108349
The
class_existscheck and the condition$definition instanceof ChildDefinitionhave been swapped with#61215 in order to produce an error if a service is not available.This error was later relaxed in#61270, but the executing order of the condition kept to be
class_existsfirst, theninstanceof.That means, if
class_existsfails with a PHP error (like PHP Fatal Error: Interface "My\Vendor\MyInterface" not found`) affected uses will not see the deprecation, but a fatal error instead.