Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translation] Add translation domain switcher#62518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jannes-io wants to merge1 commit intosymfony:8.1
base:8.1
Choose a base branch
Loading
fromjannes-io:translation-domain-switcher

Conversation

@jannes-io
Copy link

@jannes-iojannes-io commentedNov 26, 2025
edited by OskarStark
Loading

QA
Branch?8.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#62517
LicenseMIT

see#62517

@carsonbotcarsonbot added this to the8.1 milestoneNov 26, 2025
@carsonbotcarsonbot changed the title[Translator] Add translation domain switcher[Translation] Add translation domain switcherNov 26, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@jannes-iojannes-ioforce-pushed thetranslation-domain-switcher branch fromec38957 to91dc112CompareNovember 26, 2025 15:04
@jannes-iojannes-ioforce-pushed thetranslation-domain-switcher branch from91dc112 tob5f8dc8CompareNovember 26, 2025 15:05
@stof
Copy link
Member

-1 for that. See#62517 (comment) for my reasons.

@jannes-iojannes-io marked this pull request as draftNovember 26, 2025 15:23
@jannes-io
Copy link
Author

Going to tackle the added interface issue, I'm sure we can do without modifyingTranslator.php's implements.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@welcoMatticwelcoMatticAwaiting requested review from welcoMatticwelcoMattic is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

[Translation] add option to change translation domain on the fly

3 participants

@jannes-io@carsonbot@stof

[8]ページ先頭

©2009-2025 Movatter.jp