Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.8k
[Validator] verify spanish translations with state needs-review-translation#62501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Conversation
carsonbot commentedNov 24, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Gonzalo1987 commentedNov 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
(Spanish native) In general, I prefer the existing translations as they were before the pull request, except for adding the accent on the word vídeo. Also, the existing translations are generally more accurate compared to the original phrases. |
stof commentedNov 26, 2025
This change was requested by other reviewers in github.com//pull/62239 |
Gonzalo1987 commentedNov 26, 2025
I humbly accept it, "anchura" is also correct but it seemed less formal to me, if "altura" is being used in the same context it makes a lot of sense. 🙏 |
Spomky left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍🏽 Greate. Thank you. Please changeanchura intoaltura as mentioned earlier.
| <trans-unitid="43"> | ||
| <source>The image width is too big ({{ width }}px). Allowed maximum width is {{ max_width }}px.</source> | ||
| <target>El ancho de la imagen es demasiado grande ({{ width }}px).El ancho máximo permitido es de {{ max_width }}px.</target> | ||
| <target>La anchura de la imagen es demasiado grande ({{ width }}px).La anchura máxima permitida es de {{ max_width }}px.</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've just talked to a native speaker andancho is way better. :)
fabpot commentedNov 29, 2025
No, |
fperxas commentedNov 29, 2025
I'm a native speaker too. I kept I'm personaly more used to BUT :D, In fact, the sentence kinda feels weird on spanish speakers because, if we want to honor Cervantes, we might have to rephrase the whole sentece which, i don't know, if it's ok with everybody:
And so on with the height:
I'm open to push whatever feels the best for everybody. I, myself, vote for the last ones. |
Gonzalo1987 commentedNov 29, 2025
I prefer the last ones too <3 |
Keeping the same text as the original PR#62239 by@cstdl
This PR verifies the Spanish (es) translations for the Validator component, following the existing style and tone used in other translations.
Why
The Spanish translation file "validators.es.xlf" contained several strings with state "needs-review-translation" that exist in other languages.
How
Before/After
Before: Unchecked translation entries in "validators.es.xlf"
After: All validator strings now translated and verified in Spanish.
A few extras to the original PR
I have added all the mentions written and reviewed on the original PR.