Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] verify spanish translations with state needs-review-translation#62501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fperxas wants to merge1 commit intosymfony:6.4
base:6.4
Choose a base branch
Loading
fromfperxas:6.4

Conversation

@fperxas
Copy link

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
IssuesFix#61641
LicenseMIT

Keeping the same text as the original PR#62239 by@cstdl

This PR verifies the Spanish (es) translations for the Validator component, following the existing style and tone used in other translations.

Why

The Spanish translation file "validators.es.xlf" contained several strings with state "needs-review-translation" that exist in other languages.

How

  • Updated: "src/Symfony/Component/Validator/Resources/translations/validators.es.xlf"

Before/After

Before: Unchecked translation entries in "validators.es.xlf"
After: All validator strings now translated and verified in Spanish.

A few extras to the original PR

I have added all the mentions written and reviewed on the original PR.

@carsonbotcarsonbot added this to the6.4 milestoneNov 24, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleverify spanish translations with state needs-review-translation - replacing apparently stalled PR #62239 verify spanish translations with state needs-review-translation - replacing apparently stalled PR #62239Nov 24, 2025
@Gonzalo1987
Copy link

Gonzalo1987 commentedNov 26, 2025
edited
Loading

(Spanish native) In general, I prefer the existing translations as they were before the pull request, except for adding the accent on the word vídeo.
It is possible to useancho instead ofanchura, as shown here:
https://dle.rae.es/ancho

Also, the existing translations are generally more accurate compared to the original phrases.

@stof
Copy link
Member

It is possible to useancho instead ofanchura,

This change was requested by other reviewers in github.com//pull/62239

@Gonzalo1987
Copy link

It is possible to useancho instead ofanchura,

This change was requested by other reviewers in github.com//pull/62239

I humbly accept it, "anchura" is also correct but it seemed less formal to me, if "altura" is being used in the same context it makes a lot of sense. 🙏

fperxas reacted with thumbs up emoji

Copy link
Contributor

@SpomkySpomky left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍🏽 Greate. Thank you. Please changeanchura intoaltura as mentioned earlier.

@OskarStarkOskarStark changed the title verify spanish translations with state needs-review-translation - replacing apparently stalled PR #62239 verify spanish translations with state needs-review-translationNov 29, 2025
@carsonbotcarsonbot changed the title verify spanish translations with state needs-review-translation[Validator] verify spanish translations with state needs-review-translationNov 29, 2025
<trans-unitid="43">
<source>The image width is too big ({{ width }}px). Allowed maximum width is {{ max_width }}px.</source>
<target>El ancho de la imagen es demasiado grande ({{ width }}px).El ancho máximo permitido es de {{ max_width }}px.</target>
<target>La anchura de la imagen es demasiado grande ({{ width }}px).La anchura máxima permitida es de {{ max_width }}px.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've just talked to a native speaker andancho is way better. :)

@fabpot
Copy link
Member

👍🏽 Greate. Thank you. Please changeanchura intoaltura as mentioned earlier.

No,anchura is width andaltura is height.

@fperxas
Copy link
Author

I'm a native speaker too. I keptanchura instead ofancho becausealtura instead ofalto was used throughout the file and because the reviewers on#62239 requested the change.

I'm personaly more used to
El alto/ancho del vídeo orEl ancho/ancho de la imagen thanLa anchura/altura de la imagen
So I can change both and push the changes. I also think that both should be consistent, we either useanchura/altura oralto/ancho it's better to not mix them.

BUT :D, In fact, the sentence kinda feels weird on spanish speakers because, if we want to honor Cervantes, we might have to rephrase the whole sentece which, i don't know, if it's ok with everybody:

<target>La imagen es demasiado ancha ({{ width }}px). No debe sobrepasar los {{ max_width }}px de ancho.</target>

<target>La imagen es demasiado estrecha ({{ width }}px). Como mínimo debe tener {{ min_width }}px de ancho.</target>

<target>El vídeo es demasiado ancho ({{ width }}px). No debe sobrepasar los {{ max_width }}px de ancho.</target>

<target>La vídeo es demasiado estrecho ({{ width }}px). Como mínimo debe tener {{ min_width }}px de ancho.</target>

And so on with the height:

<target>La imagen es demasiado alta ({{ height }}px). No debe sobrepasar los {{ max_height }}px de alto.</target>

<target>La imagen no es suficientemente alta ({{ height }}px). Como mínimo de tener {{ min_height }}px de alto.</target>

<target>El vídeo es demasiado alto ({{ height }}px). No debe sobrepasar los {{ max_height }}px de alto.</target>

<target>El vídeo no es suficientemente alto ({{ height }}px). Como mínimo debe tener {{ min_height }}px de alto.</target>

I'm open to push whatever feels the best for everybody. I, myself, vote for the last ones.

Gonzalo1987 reacted with heart emoji

@Gonzalo1987
Copy link

I'm a native speaker too. I keptanchura instead ofancho becausealtura instead ofalto was used throughout the file and because the reviewers on#62239 requested the change.

I'm personaly more used toEl alto/ancho del vídeo orEl ancho/ancho de la imagen thanLa anchura/altura de la imagen So I can change both and push the changes. I also think that both should be consistent, we either useanchura/altura oralto/ancho it's better to not mix them.

BUT :D, In fact, the sentence kinda feels weird on spanish speakers because, if we want to honor Cervantes, we might have to rephrase the whole sentece which, i don't know, if it's ok with everybody:

<target>La imagen es demasiado ancha ({{ width }}px). No debe sobrepasar los {{ max_width }}px de ancho.</target>

<target>La imagen es demasiado estrecha ({{ width }}px). Como mínimo debe tener {{ min_width }}px de ancho.</target>

<target>El vídeo es demasiado ancho ({{ width }}px). No debe sobrepasar los {{ max_width }}px de ancho.</target>

<target>La vídeo es demasiado estrecho ({{ width }}px). Como mínimo debe tener {{ min_width }}px de ancho.</target>

And so on with the height:

<target>La imagen es demasiado alta ({{ height }}px). No debe sobrepasar los {{ max_height }}px de alto.</target>

<target>La imagen no es suficientemente alta ({{ height }}px). Como mínimo de tener {{ min_height }}px de alto.</target>

<target>El vídeo es demasiado alto ({{ height }}px). No debe sobrepasar los {{ max_height }}px de alto.</target>

<target>El vídeo no es suficientemente alto ({{ height }}px). Como mínimo debe tener {{ min_height }}px de alto.</target>

I'm open to push whatever feels the best for everybody. I, myself, vote for the last ones.

I prefer the last ones too <3

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@SpomkySpomkySpomky approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

7 participants

@fperxas@carsonbot@Gonzalo1987@stof@fabpot@Spomky@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp