Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix repeatable#[AsTaggedItem] to avoid double registration and ignoringcontainer.ignore_attributes#62327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
…e registration and ignoring `container.ignore_attributes`
| $reflector =null !==$class ?$container->getReflectionClass($class) :null; | ||
| $checkTaggedItem = !$definition->hasTag($definition->isAutoconfigured() ?'container.ignore_attributes' :$tagName); | ||
| foreach ($attributesas$attribute) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This loop is about looping over the various tags added explicitly in the service definition. Anything that skips this loop is broken by design. Explicit tag attributes must win over the AsTaggedItem attribute providing autoconfigured fallback values (see the priority of values inPriorityTaggedServiceUtil::getDefault())
Uh oh!
There was an error while loading.Please reload this page.
More reviewablewithout whitespaces